Bugzilla – Full Text Bug Listing
| Summary: | [Package Explorer] "Link with Editor" state not saved | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Elmar Sonnenschein <develop> | ||||
| Component: | Mylyn | Assignee: | Mik Kersten <mik.kersten> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P1 | CC: | bigguy, bradcupit, chris, jason, mauromol, maxim, remy.suen, robert.elves, rooneyp1976, steffen.pingel, thelenin, tompik, xphiler69 | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 2.1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Elmar Sonnenschein
Works for me for both the package and project explorers in RC4 in WinXP. If there are more details to provide then feel free to reopen. I found out that this is caused by Mylyn which is bundled by default with the Java development download. If I deactivate the Mylyn plugin, restart, and then re-activate it again the "Link with Editor" state is saved correctly afterwards. Should I re-open this bug or submit a new one? Reopening to move to Mylyn *** Bug 195676 has been marked as a duplicate of this bug. *** *** Bug 195493 has been marked as a duplicate of this bug. *** (In reply to comment #3) > Reopening to move to Mylyn Would it be better to physically reassign it to Mylyn so that they actually get a notification that a bug's gone their way without having to run a random query and go "oh hey we have a bug"? *** Bug 196047 has been marked as a duplicate of this bug. *** (In reply to comment #6) > Would it be better to physically reassign it to Mylyn so that they actually get > a notification that a bug's gone their way without having to run a random query > and go "oh hey we have a bug"? Yes, reassigning to us or CC'ing me is the right way to get our attention. Just a clarification of the workaround I mentioned: it is necessary to activate "Link with Editor" once with Mylyn deactivated before re-activating it. Afterwards the editor linking should be restored correctly (tried it on several Eclipse installations). I could not make the linking work. I tried several combinations of MyLyn on/off, enabling the linking, stop Eclipse from the red X, and from File/Exit, starting with the -clean option. I have a new install of Eclipse 3.3, MyEclipse 6.0, RegEx tester, and using Java 1.6. *** Bug 201897 has been marked as a duplicate of this bug. *** As suggested by Mik, I'm reporting my own experience with "Link with Editor" function. My problem is not related to the persistence of "Link with Editor" option: my problem is that even while "Link with Editor" is ENABLED, the selection in the package explorer IS NOT synchronized with the editor, as it should. If I move the cursor in the editor from one method to another (or from the inside of a method to the outside) the selection in the package explorer is lost (i.e.: NOTHING is selected anymore), even if I'm still working on the same class. If I move to another class (for instance using CTRL+SHIFT+T), the selection in the package explorer moves to the new class, but goes away as soon as I move the cursor in the editor. Please note that I have unchecked the option "Show members in Package Explorer" under Java | Appearance preferences page. Fixed. This turned out to be a tricky problem. There was a simple bug with the scenario listed in the description, where the state would not be preserved on restart if no task was ever activated. Comment#12 pointed out a more complex bug with Mylyn's management of the focused mode: if the Link with Editor state was changed while a view was focused, this change would be forgotten because Mylyn would restore the state to what it was before the view was focused. To address this all views that support automatic toggling of focus now disable the Link with Editor action when focus is applied (either manually or automatically on task activation). This makes the behavior more explicit (i.e. the fact that when focused views are automatically linked with the editor) and prevents us from getting into the illegal state. In addition, all focus actions will now be disabled when there is no task active. Created attachment 79171 [details]
mylyn/context/zip
Mik, there is a very similar problem for disabling/restoring filters (like show empty parent packages). Is it going to be resolved by your fix too? Yup, it is almost certainly the same problem. The situation is a bit tricker with filters because there can be multiple items in the view menu that correspond to a filter. But I will be investigating whether we can create a similar solution later today (bug 195640). Great. The filtering issue is quite annoying and it is one of the most common complaints I hear from the end users. (In reply to comment #17) > Great. The filtering issue is quite annoying and it is one of the most common > complaints I hear from the end users. Eugene: if you hear such complaints from users it would be great if you could prompt them to vote for the corresponding bug in order to help us prioritize, in this case bug 195640, which had no votes. This bug has been partly addressed now, but depends on a new Platfrom/JDT bug that I just filed to remove the problematic interaction with dynamically added filters (bug 204627). (In reply to comment #18) > Eugene: if you hear such complaints from users it would be great if you could > prompt them to vote for the corresponding bug in order to help us prioritize, in > this case bug 195640, which had no votes. I do do that all the time, but in my observation, people have no interest to complain to the issue tracking system or project mailing lists and forums. For some mysterious reason they want to share their frustration with me. Let me give you couple random quotes: ...idea is OK, but implementation sucks It was always presented to me as the ideal GUI ...until I started using it Sad, isn't it? This discussion is probalby best for the newsgroup or another bug report on how to make general improvements to the Task-Focused UI, which you could link from here if you start it. But no, I don't find this sad but completely normal :) I have been hearing statements of this sort every since the first public release, and the main thing that's encouraging is that the ratio of praises to negative comments continues to improve on a very good trajectory. But what's happening now is that with the 2.0 release Mylyn is avaliable to the majority of Eclipse users, not just early adopters. That was an extremely drastic jump in the adoption rate of the project and some non-early adopter types are going to have bad reactions of this sort to how dramatic a change the Task-Focused UI is, and to usability/expectation issues that we still have to address (e.g. bug 195727). What we need to do for those users it to inform them that every part of the Task-Focused UI can be turned off, so I will add the following entry to the "Getting Started" page: http://wiki.eclipse.org/index.php/Mylyn_FAQ#Which_Focused_UI_features_can_I_turn_off.3F We also need to make the UI more obvious about that changes it makes to the existing UI, which is why this bug and things like Mylyn 2.1's disabling of the existing filtering actions is so important. (In reply to comment #20) > ...What we need to do for those users it to inform them > that every part of the Task-Focused UI can be turned off, I don't think that turning off something is any of the major complain there. Number of context-related bugs aren't being fixed for quite long time and those cause the major grief. See comments I added while ago and cleaned up a bit after last changes http://wiki.eclipse.org/Mylyn_3.0_Plan#Task_Context (In reply to comment #13) > Fixed. Hi Mik! I'm sorry, but the problem isn't fixed in my case. I recently updated Mylyn to 2.1, but the selection in my package explorer still disappear as soon as I click in the editor. The "link with editor" seems to be pressed, but it is disabled, so I can't even do the trick described in my comment #9 to update the selection in the package explorer (turn off and on again "link with editor"). The function works perfectly as soon as I disable the "focus on active task" option in the package explorer... Today I noticed another problem with Mylyn 2.1: I started Eclipse, while a task was still active from the previous session. I deactivated it, created a new local task and activated it. The "Focus on active task" in Package Explorer was disabled (grayed out)! I couldn't select it in any way. I had to check the "Link with editor" button, in order to get "Focus on active task" enabled! From that moment on, I could check and uncheck both "Focus on active task" and "Link with editor" correctly. Anyway, I confirm that, in my case, when "Focus on active task" is checked the "Link with editor" function doesn't work yet. Maybe the problem is that I have unchecked the option "Show members in Package Explorer" under Java | Appearance preferences page? I think this problem is quite annoying, because the "Link with editor" feature is very important to me... Thanks in advance, Mauro. (In reply to comment #23) > Today I noticed another problem with Mylyn 2.1: I started Eclipse, while a task > was still active from the previous session. I deactivated it, created a new > local task and activated it. The "Focus on active task" in Package Explorer was > disabled (grayed out)! I couldn't select it in any way. I had to check the "Link > with editor" button, in order to get "Focus on active task" enabled! From that > moment on, I could check and uncheck both "Focus on active task" and "Link with > editor" correctly. Mauro: this is almost certainly a duplicate of bug 204951, which is related to the laziness of view/action instantiation. Please comment on that bug it doesn't already describe your use case. > Anyway, I confirm that, in my case, when "Focus on active task" is checked the > "Link with editor" function doesn't work yet. Maybe the problem is that I have > unchecked the option "Show > members in Package Explorer" under Java | Appearance preferences page? > > I think this problem is quite annoying, because the "Link with editor" feature > is very important to me... Yup, it sounds like the Mylyn linking functionality is not correctly linking when Members are filtered (it's default is to link to the exact element, not to the file as is the standard behavior in the Package Explorer). Please open a new bug for this. *** Bug 207280 has been marked as a duplicate of this bug. *** *** Bug 207304 has been marked as a duplicate of this bug. *** Daniel: are people still seeing this original bug with the 2.1 release of Mylyn or with 2.0? I took a quick look and can't reproduce with Myl,yn 2.1 (i.e. "Link with Editor" state is preserved after restart). *** Bug 211911 has been marked as a duplicate of this bug. *** Jason: note that this bug should be fixed with the latest Mylyn 2.1, but we still have related bug 205548 (scheduled for the Dec. 19th Mylyn 2.2). (In reply to comment #29) > Jason: note that this bug should be fixed with the latest Mylyn 2.1, but we > still have related bug 205548 (scheduled for the Dec. 19th Mylyn 2.2). > Thanks Mik |