Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 195126

Summary:	Remove invalid dependency on org.eclipse.emf.query.ocl from features/org.eclipse.gmf.sdk*/feature.xml
Product:	[Modeling] GMP	Reporter:	Andrey Mishustin <andrey.mishustin>
Component:	Releng	Assignee:	Richard Gronback <richard.gronback>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	mfeldman, richard.gronback, tikhomirov.artem
Version:	2.0	Keywords:	plan
Target Milestone:	2.1
Hardware:	All
OS:	All
Whiteboard:

Description Andrey Mishustin

2007-07-02 09:02:38 EDT

Build ID: I20070625-1500

Steps To Reproduce:
After installing latest releases of GMF (2.0) and EMF-query (1.1) SDKs platform claims:
====
Graphical Modeling Framework SDK (2.0.0.v20070608-1300-7f79CEEMnX9yDju9K-GK7_saZ8w1) requires plug-in "org.eclipse.emf.query.ocl (1.0.1)", or compatible.
====
In fact, GMF SDK doesn't depend on org.eclipse.emf.query.ocl at all, so following line:
====
<import plugin="org.eclipse.emf.query.ocl" version="1.0.1" match="compatible"/>
====
should be just removed from features/org.eclipse.gmf.sdk*/feature.xml

More information:

Comment 1 Richard Gronback

2008-05-12 16:28:25 EDT

The *.emf.query.ocl plug-in is no longer listed as a dependency in the SDK feature.  But, I do see two references to it elsewhere:

- the org.eclipse.gmf.examples feature lists it, though I doubt it's required (Max will remove)
- the test org.eclipse.gmf.test.migration.MigrationPatchesTest references it as well, though I also doubt this plug-in is really required.  Artem?

Comment 2 Richard Gronback

2008-05-12 16:51:53 EDT

(In reply to comment #1)
> the test org.eclipse.gmf.test.migration.MigrationPatchesTest references it as well

This same test references org.eclipse.emf.ocl, which we're replacing throughout GMF with references to org.eclipse.ocl per bug 194633.  There are also references to org.eclipse.emf.ocl and *.query.ocl in the test's /models/migration/testRequiredPluginsMoved.gmfgen model.

Comment 3 Artem Tikhomirov

2008-05-13 13:28:52 EDT

(In reply to comment #2)
The references you mention are not real 'references', it's merely checking values returned from the model, which is nothing but string. It doesn't prevent us from dropping dependency from oe.emf.query.ocl. Though, implementation of required plugins method from GMFGen should be updated anyway.

Comment 4 Richard Gronback

2008-05-13 13:55:27 EDT

(In reply to comment #3))
> The references you mention are not real 'references', it's merely checking
> values returned from the model, which is nothing but string. 

Right, they are references as stated, and not dependencies.

> It doesn't prevent us from dropping dependency from oe.emf.query.ocl. 

Done, verified using N200805121942.  Closing this bug.

> Though, implementation of required plugins method from GMFGen should be updated anyway.

This can be handled under another bug.

Comment 5 Artem Tikhomirov

2008-05-14 08:00:01 EDT

(In reply to comment #4)
These were mere strings to ensure migration didn't lost any plugin id. Anyway, I've replaced them with fake identities not to get confused once again.

Comment 6 Richard Gronback

2008-08-13 13:09:56 EDT

[target cleanup] 2.1 RC was the original target milestone for this bug

Comment 7 Eclipse Webmaster

2010-07-19 22:06:41 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Releng was the original product and component for this bug