Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 194936

Summary: attachment names are not displaying for connectors by default
Product: z_Archived Reporter: matt deegler <mdeegler>
Component: MylynAssignee: Frank Becker <eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: eclipse, robert.elves
Version: unspecifiedKeywords: helpwanted
Target Milestone: 3.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch
none
mylyn/context/zip
none
Tooltip Patch
none
mylyn/context/zip
none
Patch with table viewer tooltips api
none
mylyn/context/zip none

Description matt deegler CLA 2007-06-29 12:22:14 EDT
org.eclipse.mylyn.tasks.ui.editors.AbstractRepositoryTaskEditor does not display the attachment name, just description, Type, Creator, and Created.

Attachment name should be added as the first column for the atttachments section.
Comment 1 Mik Kersten CLA 2007-06-29 14:17:09 EDT
I'll mark this helpwanted for now, since a patch could get this into 2.1.
Comment 2 Frank Becker CLA 2007-07-27 18:01:25 EDT
Created attachment 74839 [details]
Patch

Hope this is what you want.
Comment 3 Frank Becker CLA 2007-07-27 18:01:30 EDT
Created attachment 74840 [details]
mylyn/context/zip
Comment 4 Eugene Kuleshov CLA 2007-07-27 18:21:33 EDT
Looks good, except that it increases minimum width of the task editor. Maybe we need to do something about adjusting that width and resize column sizes accordingly or at least make default colum widths smaller (i.e. the date one is way too wide).
Comment 5 Robert Elves CLA 2007-07-27 22:40:47 EDT
Frank, this is exactly what we were looking for but after testing this out I'm not sure I like having the file name as a column. For the most part is seems like a lot of visual noise to me with file extensions etc. Is there an alternative way to expose this information that would be suitable for example as a tooltip (on the leading image if possible). Note that the file name is hidden within the bugzilla web ui and the filename isn't available in the data stream from Bugzilla 2.18 (although there are painful ways of retrieving it). Additionally Eugene's point regarding width is already a problem with this table. Thoughts?
Comment 6 Frank Becker CLA 2007-07-29 17:22:03 EDT
 (In reply to comment #5)
> Frank, this is exactly what we were looking for but after testing this out I'm
> not sure I like having the file name as a column. For the most part is seems
> like a lot of visual noise to me with file extensions etc. Is there an
> alternative way to expose this information that would be suitable for example as
> a tooltip (on the leading image if possible). Note that the file name is hidden
> within the bugzilla web ui and the filename isn't available in the data stream
> from Bugzilla 2.18 (although there are painful ways of retrieving it).
> Additionally Eugene's point regarding width is already a problem with this
> table. Thoughts?

What's about to have a window over the attachment  with all the possible information like in Task List.
Can you point me to the class/action where this is implemented so that I can look if this is possible to implement
Comment 7 Eugene Kuleshov CLA 2007-07-29 19:04:55 EDT
Look at TaskListToolTipHandler, though I won't recommend to directly copy that class and it is better to use JFace tooltip support. See http://wiki.eclipse.org/index.php/JFaceSnippets
Comment 8 Frank Becker CLA 2007-08-01 16:41:38 EDT
Created attachment 75168 [details]
Tooltip Patch

 I create code to setup an tooltip for the attachment.

But please look at the implementation, because it is the first time I do UI code.
Comment 9 Frank Becker CLA 2007-08-01 16:41:39 EDT
Created attachment 75169 [details]
mylyn/context/zip
Comment 10 Robert Elves CLA 2007-08-09 16:50:32 EDT
I think rather than create these tool tips from scratch we may be able to make use of new table viewer tooltips api. For a starting point see:

http://dev.eclipse.org/newslists/news.eclipse.platform.swt/msg33993.html
Comment 11 Frank Becker CLA 2007-08-10 16:57:36 EDT
Created attachment 75890 [details]
Patch with table viewer tooltips api

I create a new patch with the requested tooltip api

(In reply to comment #10)
> I think rather than create these tool tips from scratch we may be able to make
> use of new table viewer tooltips api. For a starting point see:
> 
> http://dev.eclipse.org/newslists/news.eclipse.platform.swt/msg33993.html
>
Comment 12 Frank Becker CLA 2007-08-10 16:57:39 EDT
Created attachment 75891 [details]
mylyn/context/zip
Comment 13 Frank Becker CLA 2007-08-13 01:11:39 EDT
The patch in comment #11 is only for Eclipse 3.3. What is to do for Eclipse 3.2 ?

(In reply to comment #10)
> I think rather than create these tool tips from scratch we may be able to make
> use of new table viewer tooltips api. For a starting point see:
> 
> http://dev.eclipse.org/newslists/news.eclipse.platform.swt/msg33993.html
> 

Comment 14 Robert Elves CLA 2007-08-14 02:25:00 EDT
Perfect. Patch applied, ip log updated. I'm going to trim back the amount of information in the tool tip just to the filename for now since most of the other info is available within the table. We can iterate on this if necessary. 
 
 (In reply to comment #13)
> The patch in comment #11 is only for Eclipse 3.3. What is to do for Eclipse 3.2
This feature will not be supported in the 3.2 build unless you want to contribute 3.2 specific functionality?

Feel free to mark resolved though since 3.3 functionality is great and if we want to do 3.2 we can open a new bug report for that.
Comment 15 Frank Becker CLA 2007-08-14 17:28:24 EDT
 (In reply to comment #14)
> Perfect. Patch applied, ip log updated. I'm going to trim back the amount of
> information in the tool tip just to the filename for now since most of the other
> info is available within the table. We can iterate on this if necessary.
> 
> (In reply to comment #13)
> > The patch in comment #11 is only for Eclipse 3.3. What is to do for Eclipse
> 3.2
> This feature will not be supported in the 3.2 build unless you want to
> contribute 3.2 specific functionality?
> 
> Feel free to mark resolved though since 3.3 functionality is great and if we
> want to do 3.2 we can open a new bug report for that.
If for 3.2 needed we do an other bug.