Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 193543

Summary:	ReportWindowWizard unnecessarily slows down report process
Product:	z_Archived	Reporter:	Joe Toomey <jptoomey>
Component:	TPTP	Assignee:	Paul Slauenwhite <paulslau>
Status:	CLOSED FIXED	QA Contact:
Severity:	major
Priority:	P1	CC:	paulslau
Version:	unspecified	Keywords:	plan
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:
Bug Blocks:	179037

Description Joe Toomey

2007-06-20 11:20:01 EDT

org.eclipse.hyades.test.tools.ui.common.internal.report.ReportWindowWizard.isAvailable() is called when the Report context menu is chosen on an element in the test navigator (before the list of available reports is displayed.)  The implementation of this method has a side effect of populating a map of all test suites to their execution results, which is needed to run this particular report (even though this may not be the report chosen.)  This consumes memory unnecessarily, and can cause a very long delay before the user is prompted with the available reports (during which there is no progress monitor or cancel ability.)

Suggest moving this logic to the generate() method, and simply returning true as soon as the first in-range execution history is found.

Comment 1 Joe Toomey

2007-08-22 20:32:45 EDT

No time to address this in 4.4.1.  Retarget to 4.5.

Comment 2 Paul Slauenwhite

2007-08-27 11:06:32 EDT

Will address in 4.5.

Comment 3 Paul Slauenwhite

2007-11-27 10:44:22 EST

The isAvailable() method for all report types handles (aside other report-specific tasks, such as checking if BIRT is available):

-Determine if the selection contains at least one element.
-Determine if the selection element contains test suite(s) and resolve the selected test suite(s).
Determine if at least one test suite has been selected.

The following files checked-in to CVS (HEAD):

org.eclipse.tptp.test.report.birt.ui.internal.ReportXMLLogWizard.java
org.eclipse.tptp.test.report.birt.ui.internal.BIRTTabularReportWizard.java
org.eclipse.tptp.test.report.birt.ui.internal.BIRTTestPassReportWizard.java
org.eclipse.tptp.test.report.birt.ui.internal.BIRTTestReport.java
org.eclipse.tptp.test.report.birt.ui.internal.GenericTestReportWizard.java
org.eclipse.hyades.test.tools.ui.common.internal.report.jscrib.ReportDataUtils.java
org.eclipse.hyades.test.tools.ui.common.internal.report.ReportWindowWizard.java
org.eclipse.hyades.test.tools.ui.common.internal.report.TestPassReportWizard.java
org.eclipse.hyades.test.tools.ui.http.internal.reports.HTTPReportGenerator.java

Comment 4 Paul Slauenwhite

2009-02-25 11:56:05 EST

Closing by default since not closed by the originator in the 7+ months since
being resolved.  

Please reopen if the issue is still present in the latest TPTP release or the
resolution is not correct.