Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 193412

Summary: [UI] Contacts view issues when users going offline
Product: [RT] ECF Reporter: Chris Aniszczyk <caniszczyk>
Component: ecf.uiAssignee: Remy Suen <remy.suen>
Status: CLOSED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: slewis
Version: 1.0.0 ReleaseKeywords: helpwanted
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch to run a full refresh if there are filters. none

Description Chris Aniszczyk CLA 2007-06-19 17:37:15 EDT
In the contacts view, if you're signed into a view and only have it showing "online" users, if one of those users goes offline, he/she remains in the list but show in the disconnected state. It would be nice if the filtering was reapplied to get the view in the correct state.
Comment 1 Scott Lewis CLA 2007-06-19 19:15:08 EDT
Assigning to Remy as he is only one familiar with the filtering code right now.  Remy can you address this before Europa? or should I reassign...as I think it's a pretty severe problem (affects all providers).
Comment 2 Remy Suen CLA 2007-06-19 20:21:34 EDT
I don't think this should be too difficult for me to whip up a quick fix. My Internet at home is rather shaky so I doubt I can get much good testing done. I will try to get this addressed during my lunch break tomorrow.

I am away on Thursday to Sunday, so if I do not get this done tomorrow, I will let you know on this bug, Scott.
Comment 3 Remy Suen CLA 2007-06-20 07:38:55 EDT
Created attachment 71862 [details]
Patch to run a full refresh if there are filters.

I'm not sure if this is the right way, but it does fix the issue. The idea here is that if the viewer has attached viewers, we'll call refresh so that it will check its model input again and figure out whether to show something or not.
Comment 4 Scott Lewis CLA 2007-06-20 13:23:12 EDT
(In reply to comment #3)
> Created an attachment (id=71862) [details]
> Patch to run a full refresh if there are filters.
> 
> I'm not sure if this is the right way, but it does fix the issue. The idea here
> is that if the viewer has attached viewers, we'll call refresh so that it will
> check its model input again and figure out whether to show something or not.
> 

Tested.  +1 on commit.

Comment 5 Remy Suen CLA 2007-06-20 13:29:42 EDT
I mean to say whether the viewer has attached filters or not.

Anyway, committed to CVS HEAD.
Comment 6 Scott Lewis CLA 2008-05-18 19:17:16 EDT
closing.