Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 193114

Summary:

[Repo View] "Unable to Discard Location" dialog has bad resizing behavior

Product:

[Eclipse Project] Platform

Reporter:

Dani Megert <daniel_megert>

Component:

Team

Assignee:

Platform Team Inbox <platform-team-inbox>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

markus.kell.r, Szymon.Brandys, tomasz.zarna

Version:

3.3

Keywords:

helpwanted

Target Milestone:

3.4 M1

Hardware:

OS:

Windows XP

Whiteboard:

hasPatch

Attachments:

Description	Flags
Fix	none
Fix with wrapping list title	none
Resized dialog	none

Description Dani Megert

2007-06-18 10:24:22 EDT

3.3 RC4

The "Unable to Discard Location" dialog has bad resizing behavior: resizing is futile as the list doesn't grow.

Comment 1 Dani Megert

2007-06-21 07:16:04 EDT

The dialog comes from Team (DetailsDialogWithProjects).

Comment 2 Dani Megert

2007-06-21 07:18:42 EDT

Created attachment 72025 [details]
Fix

Besides fixing the layouting issues it also
- removes the ugly code that displays the details title by adding as first
  item to the list by adding a label in front of the list
- set the list height to 5 items
- fixes Javadoc warnings

Comment 3 Dani Megert

2007-06-28 08:15:21 EDT

*** Bug 110625 has been marked as a duplicate of this bug. ***

Comment 4 Dani Megert

2007-06-28 08:49:40 EDT

My patch has a problem when long list titles are provided like in the scenario from bug 110625.

I'll provide a new patch that fixes both issues.

Comment 5 Dani Megert

2007-06-28 09:06:18 EDT

Created attachment 72679 [details]
Fix with wrapping list title

Comment 6 Michael Valenta

2007-06-28 09:57:08 EDT

Patch released to HEAD. Thanks Dani.

Comment 7 Tomasz Zarna

2007-08-07 05:11:01 EDT

Created attachment 75509 [details]
Resized dialog

I would suggest reopening the bug in order to fix resizing behavior shown on the screen shot. We should keep dialog's buttons visible as long as possible. This is the way I've seen it's done on other dialogs too (e.g. Open Resource, Move Project, wizards).

Comment 8 Dani Megert

2007-08-07 05:16:47 EDT

The original bug is about the list being fixed size. AFAIK the problem you report was there forever. I suggest you open a separate bug.

Comment 9 Tomasz Zarna

2007-08-07 10:50:54 EDT

A separate bug opened, so we can mark this one as verified.