Bugzilla – Full Text Bug Listing
| Summary: | [ErrorHandling] Bad error handling in Workbench.runUI() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Kim Horne <eclipse> | ||||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | bokowski, emoffatt, krzysztof.daniel | ||||||
| Version: | 3.3 | Keywords: | helpwanted | ||||||
| Target Milestone: | --- | Flags: | Szymon.Brandys:
review?
(eclipse) |
||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | stalebug | ||||||||
| Attachments: |
|
||||||||
|
Description
Kim Horne
Created attachment 89964 [details]
Patch
I am not sure if this is enough... But it looks like very trivial change... any comments are welcomed.
Created attachment 89965 [details]
mylyn/context/zip
It looks good for me. Kim? Reacting to generic throwables is dangerous. If it's an OutOfMemory or out of handleor some other type of severe error trying to handle it could also fail. I'd like to get some more opinions on this. Boris? Eric? You had some pretty interesting ideas about handling catastrophic failures before... This is similar to my point in not having a 'generic' flag to allow control of the response to an Error/Warning passed into the StatusManager; we have to at least try to identify 'recoverable' vs 'catastrophic' conditions. The current idea is to use the 'code' field to identify the exceptions that we've 'handled' (i.e. those for which our code should continue to work correctly). Then any exceptions that have code == 0 indicate exceptions that we either didn't generate or for which we have no 'answer' except to shut down... The exact values of the field and the identification of what value to place on each of our generated exceptions is TBD... We might look at this as part of bug 218197 which addresses some of the generated exceptions...comments? This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |