Bug 191896

Description Alexander Nyßen 2007-06-11 04:06:59 EDT

Build ID: I20070323-1616
Currently, LayoutEditPolicy contributes to all requests from its host edit part, no matter what layout container the edit policy contributes to. 

This does not allow to have different edit policies for different layout containers belonging to a single edit part (as each edit policy will always contribute).

LayoutEditPolicy should indeed only contribute to those requests that affect edit parts whose figures are located inside its layout container (incase of a ChangeBoundsRequest) or where the creation location is inside its layout container (in case of a CreateRequest). 

To fix this, I would propose to change the getCommand method as follows:

@Override
public Command getCommand(Request request) {
  Command command = null;
  Request filteredRequest = filterRequest(request);
  if (filteredRequest != null) {
    command = super.getCommand(request);
  }
  return command;
}

public final Request filterRequest(Request request) {
  if (request instanceof CreateRequest) {
    // only process request, if the creation location is inside our
    // layout container
      if (getHostFigure().findFigureAt(((CreateRequest) request).getLocation()) == getLayoutContainer()) {
        return request;
      }
      return null;
    } else if (request instanceof ChangeBoundsRequest) {
      // filter out the edit parts that are moved/resized inside our
      // layout container
      List editParts = ((ChangeBoundsRequest) request).getEditParts();
      List filteredEditParts = new ArrayList();
      for (int i = 0; i < editParts.size(); i++) {
      if (((GraphicalEditPart) editParts.get(i)).getFigure().getParent() == getLayoutContainer()) {
        filteredEditParts.add(editParts.get(i));
      }
    }
    if (filteredEditParts.size() > 0) {
      // create a copy with the resulting edit parts
      ChangeBoundsRequest copy = new ChangeBoundsRequest();
      copy.setExtendedData(((ChangeBoundsRequest) request).getExtendedData());
      copy.setLocation(((ChangeBoundsRequest) request).getLocation());
      copy.setCenteredResize(((ChangeBoundsRequest) request).isCenteredResize());
      copy.setConstrainedMove(((ChangeBoundsRequest) request).isConstrainedMove());
      copy.setConstrainedResize(((ChangeBoundsRequest) request).isConstrainedResize());
      copy.setMoveDelta(((ChangeBoundsRequest) request).getMoveDelta());
      copy.setResizeDirection(((ChangeBoundsRequest) request).getResizeDirection());
      copy.setSizeDelta(((ChangeBoundsRequest) request).getSizeDelta());
      copy.setEditParts(filteredEditParts);
      return copy;
    }
    return null;
  }
  return null;
}

More information: