Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 191483

Summary:	JSP editor's include-prelude/coda support doesn't consider multiple jsp-property-groups
Product:	[WebTools] WTP Source Editing	Reporter:	gamerson
Component:	jst.jsp	Assignee:	Nitin Dahyabhai <thatnitind>
Status:	VERIFIED FIXED	QA Contact:	David Williams <david_williams>
Severity:	normal
Priority:	P2
Version:	2.0
Target Milestone:	2.0.1 M201
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description gamerson

2007-06-07 10:08:32 EDT

bug#109721 adds support for processing include-prelude/code jsp fragments when editing or validating jsp files.  

I was testing this feature and it seems to work well for the single <jsp-property-group> case.  However, if you have a more complex web.xml with multiple <jsp-property-group> statements, then it seems the current implementation doesn't take anything past the 1 property group into account.

Consider the following snippet of web.xml

	<jsp-config>
		<jsp-property-group>
			<display-name>test1</display-name>
			<url-pattern>/test1/*</url-pattern>
			<include-prelude>/includes/test1.jspf</include-prelude>
		</jsp-property-group>
		<jsp-property-group>
			<display-name>test2</display-name>
			<url-pattern>/test2/*</url-pattern>
			<include-prelude>/includes/test2.jspf</include-prelude>
		</jsp-property-group>
	</jsp-config>

In this case any jsp files that match the 2nd url pattern wont have the correct include-preludes fragments available.  

I realize that the most common use-case is just one <jsp-property-group> and the current implementation works fine.  But I wanted to reopen this PR to discuss the multiple property group use-case.

Comment 1 gamerson

2007-06-07 10:09:55 EDT

I would have reopened bug#109721 since its implementation seems incomplete, but I didn't have permission to reopen that bug so I created this new one.

Comment 2 Nitin Dahyabhai

2007-08-29 19:19:01 EDT

The support is "complete" in that more than one property group is allowed, it's just that the matching algorithm to choose the right property group is not working properly in 2.0.0.

So a new bug was actually the right thing to do.

Comment 3 Nitin Dahyabhai

2007-09-03 05:23:13 EDT

Fixed, both to support more than one defined property group properly and to support more than one matching property group at once.

Comment 4 Nitin Dahyabhai

2007-09-19 18:48:58 EDT

Verified with 2.0.1RC3-20070918164730.