Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 191347

Summary: Make OverlayScrollPaneLayout visible
Product: [Tools] GEF Reporter: Pratik Shah <ppshah>
Component: GEF-Legacy GEF (MVC)Assignee: gef-inbox <gef-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.2   
Target Milestone: 3.3.0 (Europa)   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Pratik Shah CLA 2007-06-06 15:58:13 EDT 
OSPL is package-protected.  It's generic and useful so could be made a public class, even though it would remain in an internal package.
Comment 1 Pratik Shah CLA 2007-06-06 16:00:57 EDT 
I can make this change if it can be approved for 3.3.  It's entirely safe and technically not a change in the API since the class is in an internal package.  Anthony, Randy, thoughts?
Comment 2 Anthony Hunter CLA 2007-06-06 16:09:20 EDT 
Since this is not a critical issue we can do for 3.4 RC1?
Comment 3 Pratik Shah CLA 2007-06-06 16:26:50 EDT 
Did you mean 3.4M1?  Or 3.3.1?  The difference is that we'll have to wait a whole year before we can use it, and only when our product moves up to Eclipse 3.4.
Comment 4 Anthony Hunter CLA 2007-06-07 08:29:58 EDT 
OK, since there is zero chance this can break anyone, I will make it so for RC3 which is June 13 2007, next week's build.
Comment 5 Randy Hudson CLA 2007-06-07 11:29:24 EDT 
This layout can't properly handle having both scrollbars at the same time. They would overlap at the corners. I think if a GEF client wants to reuse this, the "scrollpane" should just support 4/8 clickables, for NSEW.

But, since it's still in an internal package, I don't see any "committment" risk by making it visible.
Comment 6 Pratik Shah CLA 2007-06-08 15:49:53 EDT 
Done.
Comment 7 Anthony Hunter CLA 2007-06-08 16:14:01 EDT 
do you not get internal warnings in your code though?
Comment 8 Pratik Shah CLA 2007-06-09 18:10:15 EDT 
Yes, we do.  But a warning is much better than having to copy the class (which has other legal implications as well).