Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 190796

Summary: [Martini/JPI] Thread Start event simulation during VM_Init is not JNI safe
Product: z_Archived Reporter: Asaf Yaffe <asaf.yaffe>
Component: TPTPAssignee: Asaf Yaffe <asaf.yaffe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: guru.nagarajan, ivan.g.popov, viacheslav.g.rybalov
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard: closed460
Attachments:
Description Flags
Patch for 4.4. source stream. Fixed in 4.5 none

Description Asaf Yaffe CLA 2007-06-04 09:01:07 EDT
The code that simulates a Thread Start event for threads that were started before the JVMTI VMInit event is not JNI-safe. It will fail when running with strict JNI checking (-Xcheck:jni).

This bug will cause all JVMTI Profilers to fail when the JVM is executed with the -Xcheck:jni option.
Comment 1 Asaf Yaffe CLA 2007-06-04 09:02:15 EDT
This is a low priority bug. It does not manifest itself when the JVM is invoked with its default options.

Retargetting to future.
Comment 2 Asaf Yaffe CLA 2007-09-30 10:12:23 EDT
Created attachment 79446 [details]
Patch for 4.4. source stream. Fixed in 4.5

Slava, please verify that this patch solves the problem.
Comment 3 Ivan Popov CLA 2007-10-12 04:20:41 EDT
I ran TPTP profiler tests with -Xcheck:jni option turned on against patched agent libraries with Sun's JDK 1.5 and 1.6 on Windows and Linux IA32 platforms and they all passed for me. The fix solves this problem.
Comment 4 Asaf Yaffe CLA 2007-11-20 04:15:50 EST
Bug fix checked into TPTP 4.5 (HEAD) branch
Comment 5 Paul Slauenwhite CLA 2007-12-19 07:58:57 EST
Please change the target to the 4.5 iteration when this Bugzilla was resolved.
Comment 6 Paul Slauenwhite CLA 2009-06-30 13:27:39 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 7 Paul Slauenwhite CLA 2009-06-30 14:18:21 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.