Bugzilla – Full Text Bug Listing
| Summary: | [Progress] Progress view truncates progress widgets for long task names | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Stefan Xenos <sxenos> | ||||||||||
| Component: | UI | Assignee: | Tod Creasey <Tod_Creasey> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | eclipse, markus.kell.r, samuelwu | ||||||||||
| Version: | 3.3 | Keywords: | helpwanted | ||||||||||
| Target Milestone: | 3.4 M6 | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Stefan Xenos
Created attachment 69347 [details]
Screenshot demonstrating the bug
*** Bug 219970 has been marked as a duplicate of this bug. *** Created attachment 91003 [details]
Patch
The issue is the trickiness of ScrolledComposites. Because we do not set initial sizes the link text lays itself out as long as it needs to be the full length of the string.
The gradual reduction occurs because we shorten the String when we get an update. The calculated size does not include the stop button so it gets a little smaller every update.
Note that this does not address overly long job names. We decided to discourage long job names as long detail belongs in the tasks.
Patch released for build >20080228 Created attachment 91005 [details] Patch to handle the long job name As Samuel noted in Bug 219970 CVS has long job names to this patch will handle that case as well. Released as well for build >20080228 Thank you, Tod, for investigating the problem. The patch you provided helps to keep the cancel button visible. But the button will still be hidden if the view is not wide enough. I'm wondering whether you can make the viewer in the ProgressView horizontally scrollable, like the following.
public void createPartControl(Composite parent) {
viewer = new DetailedProgressViewer(parent, SWT.MULTI|SWT.H_SCROLL);
In this way, the user at least has one more choice to get to the cancel button.
Sam please show me a screenshot where it is not wide enough with the patch applied. When I tested this fix I didn't see the button cut off so the horizontal scroll should not be required. I can add it if there is no other way but the truncation of task names was added to prevent the need for the scrollbar. Created attachment 91024 [details]
Screenshot with missing button
Hi Tod, this is the screenshot. Thanks.
Sam do you get this problem when the job starts or does it happen as a result of a resize. Also it looks like you did not apply the second patch. The first one handles long task names, the second one long job names. Tod, I had both patches applied when I did the screen capture. Your resizing question led me to try a bit more. here was my scenario. 1. I ran the action to generate the messages in progress view 2. Resized the view and close it 3. Reran my action and the cancel button was gone 4. If I restarted workbench after step two, then the cancel button would not be gone. I assume you mean 1. I ran the action to generate the messages in progress view 2. Resized the progress view and then closed the progress view 2a Reopened the progress view 3. Reran my action and the cancel button was gone Correct? you are right. Verified in I20080323-2000 |