Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 189516

Summary:	Improve code in Shapes example
Product:	[Tools] GEF	Reporter:	Sri Raguraman <srikrishnanr>
Component:	GEF-Legacy GEF (MVC)	Assignee:	Alexander Nyßen <nyssen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	nyssen
Version:	3.2
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
URL:	http://www.eclipse.org/articles/Article-GEF-diagram-editor/shape.html
Whiteboard:

Description Sri Raguraman

2007-05-28 17:11:09 EDT

Build ID: M20060629-1905

Steps To Reproduce:
1. package org.eclipse.gef.examples.shapes.model;
2. File: Shape.java
3. Method: void removeConnection(Connection conn) {
firePropertyChange() should have its last two args reversed

Original: firePropertyChange(SOURCE_CONNECTIONS_PROP, null, conn);
Should be: firePropertyChange(SOURCE_CONNECTIONS_PROP, conn, null);

More information:
Also fix the same thing in Eclipse article: http://www.eclipse.org/articles/Article-GEF-diagram-editor/shape.html

Comment 1 Alexander Nyßen

2014-08-11 17:35:35 EDT

Fixed Shape#removeConnection() to not mix new and old value when firing property changes. Committed changes to origin/master. Resolving as fixed in 3.10.0M1.