Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 189083

Summary:

[render] colored labels shifted to the right and margin smaller between icon and text

Product:

[Eclipse Project] JDT

Reporter:

Dani Megert <daniel_megert>

Component:

Assignee:

Martin Aeschlimann <martinae>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

benno.baumgartner

Version:

3.3

Flags:

daniel_megert: review+
benno.baumgartner: review+

Target Milestone:

3.3 RC2

Hardware:

OS:

Linux-GTK

Whiteboard:

Bug Depends on:

188859

Bug Blocks:

Attachments:

Description	Flags
patch	none

Description Dani Megert

2007-05-25 03:17:15 EDT

+++ This bug was initially created as a clone of Bug #188859 +++

3.3 RC1.

When enabling colored labels the icon and the text get shifted to the right and the margin between icon and text becomes smaller.

The shifting is less bad than the small (almost inexistent) margin.

This does not happen in WindowsXP. Should also check Mac.

Comment 1 Dani Megert

2007-05-25 03:18:35 EDT

From bug 188859;
>The code in OwnerDrawSupport should be using getImageBounds() and
>getTextBounds().

Patch: https://bugs.eclipse.org/bugs/attachment.cgi?id=68690

Comment 2 Martin Aeschlimann

2007-05-25 04:35:30 EDT

Created attachment 68737 [details]
patch

Does the same as the original patch, but reorganized.

Comment 3 Martin Aeschlimann

2007-05-25 04:36:51 EDT

Dani and Benno, please review.

Comment 4 Benno Baumgartner

2007-05-25 05:40:39 EDT

Patch is good and looks good on gtk

Comment 5 Dani Megert

2007-05-25 06:03:50 EDT

Patch is good.

Minor issue:
 * Copyright (c) 2000, 2007 IBM Corporation and others.
should be:
 * Copyright (c) 2007 IBM Corporation and others.

Comment 6 Martin Aeschlimann

2007-05-25 10:01:45 EDT

patch released > 20070525

Comment 7 Dani Megert

2007-05-26 05:28:42 EDT

Verified in I20070525-1350.