Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 188910

Summary: [clean up] Clean Up wizard needs too much space/is ugly
Product: [Eclipse Project] JDT Reporter: Benno Baumgartner <benno.baumgartner>
Component: UIAssignee: Benno Baumgartner <benno.baumgartner>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: markus.kell.r, martinae
Version: 3.3Flags: martinae: review+
Target Milestone: 3.3 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
fix
none
fix
none
fix none

Description Benno Baumgartner CLA 2007-05-24 09:50:04 EDT 
I20070524-0010

Very ugly dialog, needs polish. Idea is to
- Move tab folder to a dialog
- Show bullet list for selected custom clean ups
Comment 1 Benno Baumgartner CLA 2007-05-24 09:56:39 EDT 
Created attachment 68571 [details]
fix

I don't rename CleanUpSaveParticipantConfigurationModifyDialog, this name is weak:-) I want to keep the patch minimal. Better would be something like CleanUpMapModifyDialog
Comment 2 Benno Baumgartner CLA 2007-05-24 09:59:06 EDT 
Martin? I hope that's better. I think it's much better...
Comment 3 Benno Baumgartner CLA 2007-05-25 04:31:24 EDT 
Created attachment 68736 [details]
fix

Same fix, except that table has a hight hint based on the number of items in the table
Comment 4 Martin Aeschlimann CLA 2007-05-25 05:30:50 EDT 
patch is good
Comment 5 Benno Baumgartner CLA 2007-05-25 10:24:41 EDT 
Created attachment 68771 [details]
fix

After Markus review: Cap table hight to 5 entries, show scrollbars if more projects are selected.
Comment 6 Benno Baumgartner CLA 2007-05-25 10:29:19 EDT 
fixed > I20070525-0010
Comment 7 Dani Megert CLA 2007-05-26 05:50:05 EDT 
Verified in I20070525-1350: it is nicer indeed but you can select 0 or n profiles and then press Finish which is not good. But that's probably not a regression. Filed bug 189284.