Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 187580

Summary: Protect against JarProcessor exceptions
Product: [Eclipse Project] Platform Reporter: Andrew Niefer <aniefer>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Platform-Update-Inbox <platform-update-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 Flags: dejan: review+
Version: 3.3   
Target Milestone: 3.3 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
updated patch none

Description Andrew Niefer CLA 2007-05-17 11:51:50 EDT 
If there is some problem unpacking a pack.gz file during update, the JarProcessor may throw an exception.

Update should catch these exceptions and download the normal jar instead.

See bug 187396 where the downloaded pack.gz file was 0 bytes.
See also bug 185774 where ZipOutputStream threw a java.lang.InternalError
Comment 1 Andrew Niefer CLA 2007-05-17 11:54:23 EDT 
Created attachment 67669 [details]
patch

The attach patch catches throwable around jarprocessor.processJar.  In this case, we fall back to downloading the normal jar.
Comment 2 Andrew Niefer CLA 2007-05-17 11:55:17 EDT 
Dejan, what do you think about this.
Comment 3 Andrew Niefer CLA 2007-05-17 12:01:50 EDT 
Created attachment 67672 [details]
updated patch

This updated patch adds the same error handling around the fallback asLocalReference calls as there is around the call when there is no pack200 support to start with.
Comment 4 Andrew Niefer CLA 2007-05-17 12:36:06 EDT 
done in HEAD