Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 187522

Summary: SetConfig.bat fails silently when serviceconfig.xml is not writable
Product: z_Archived Reporter: Joe Toomey <jptoomey>
Component: TPTPAssignee: Jonathan West <jgwest>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: jcayne, jkubasta, samwai
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows All   
Whiteboard: closed460
Attachments:
Description Flags
SetConfig Patch none

Description Joe Toomey CLA 2007-05-17 08:12:35 EDT 
Please triage this to the TPTP Agent Controller.Config component when it is created.

If serviceconfig.xml is not writable (due to incorrect user group permissions, or in the simplest to reproduce case, if the file is marked as read-only), SetConfig.bat exits normally with no error message, although changes are not reflected in the file.

We need to emit an error message in this case.  I did not test this on Linux -- it may or may not also have an issue here.
Comment 1 jkubasta CLA 2007-05-18 09:03:50 EDT 
Would be nice to address in i4 if possible
Comment 2 Jonathan West CLA 2007-11-05 12:49:39 EST 
Created attachment 82112 [details]
SetConfig Patch
Comment 3 Jonathan West CLA 2007-11-05 12:51:19 EST 
Samson, can you review my patch? Thanks!
Comment 4 jkubasta CLA 2007-11-22 09:55:01 EST 
Samson, would you please take a few minutes to review this patch today? Thanks.
Comment 5 Samson Wai CLA 2007-11-28 14:18:07 EST 
The patch looks good.
Comment 6 jkubasta CLA 2008-01-09 11:19:59 EST 
Patch checked into CVS
Comment 7 Paul Slauenwhite CLA 2009-06-30 12:09:54 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.