Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 187242

Summary: Test report generators should not traverse the referenced suites.
Product: z_Archived Reporter: Paul Slauenwhite <paulslau>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P1 CC: jptoomey, paulslau
Version: unspecifiedKeywords: plan
Target Milestone: ---Flags: jptoomey: review+
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
org.eclipse.tptp.test.report.birt_defect_187242_patch.txt
none
org.eclipse.tptp.test.report.birt_defect_187242_patch.txt none

Description Paul Slauenwhite CLA 2007-05-16 08:36:01 EDT 
Test report generators should not traverse the referenced suites.

The intent of the referencedSuites element is to keep track of referenced test
suites to make it easier to compute closure.  For example, adding an invocation
to test suite B from test suite A will add test suite B as a referenced suite
for test suite A, unless test suite B is already referenced.  

When generating reports, the behavior a test should be traversed and not the
list of referenced test suites since this list is sometimes used as a cache for
performance reasons and is not an accurate definition of the test suite's behaviour.  For example, the referencedSuites element can be removed and the behavior of the test suite is still defined.
Comment 1 Paul Slauenwhite CLA 2007-05-16 08:36:25 EDT 
Sheldon, please provide a sizing.
Comment 2 Paul Slauenwhite CLA 2007-06-01 08:57:58 EDT 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=163110#c3 for more information.
Comment 3 Paul Slauenwhite CLA 2007-06-29 09:42:48 EDT 
Targeting to 4.5 since required to improve the stability of the Test Reports.
Comment 4 Sheldon Lee-Loy CLA 2007-08-07 11:41:23 EDT 
I assume this is a simple api.
Comment 5 Sheldon Lee-Loy CLA 2007-08-07 11:42:08 EDT 
*** Bug 196218 has been marked as a duplicate of this bug. ***
Comment 6 Paul Slauenwhite CLA 2007-08-27 15:07:12 EDT 
Created attachment 77061 [details]
org.eclipse.tptp.test.report.birt_defect_187242_patch.txt
Comment 7 Paul Slauenwhite CLA 2007-08-27 15:08:08 EDT 
Joe, please review this patch.
Comment 8 Paul Slauenwhite CLA 2007-08-29 11:17:36 EDT 
Created attachment 77261 [details]
org.eclipse.tptp.test.report.birt_defect_187242_patch.txt

New patch with the following benefits:

1) Similar since it uses the facade for the behavioral model.
2) Improved performance and memory usage since it uses a single list.
Comment 9 Paul Slauenwhite CLA 2007-08-29 11:18:31 EDT 
Updated hours worked for new implementation and testing.
Comment 10 Joe Toomey CLA 2007-09-27 12:03:23 EDT 
Reviewed and discussed with Paul -- looks fine.
Comment 11 Paul Slauenwhite CLA 2007-10-03 10:33:31 EDT 
Patch checked-in to CVS (HEAD).
Comment 12 Paul Slauenwhite CLA 2007-11-07 06:22:32 EST 
Bulk update of the target field to reflect the change in iteration numbers.
Comment 13 Paul Slauenwhite CLA 2007-11-07 06:29:44 EST 
Bulk update of the target field to reflect the change in iteration numbers.
Comment 14 Paul Slauenwhite CLA 2007-11-20 13:36:27 EST 
Verified using TPTP-4.5.0-200711050917.