Bugzilla – Full Text Bug Listing
| Summary: | [WorkbenchParts] Restarting with Open Editor Horribly Broken in M7 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | Adam Cabler <acabler> | ||||||||
| Component: | GEF-Legacy GEF (MVC) | Assignee: | gef-inbox <gef-inbox> | ||||||||
| Status: | RESOLVED WORKSFORME | QA Contact: | |||||||||
| Severity: | major | ||||||||||
| Priority: | P3 | CC: | eclipse, jakub.jurkiewicz, nyssen, pwebster, Silenio_Quarti, steve_northover, Tod_Creasey | ||||||||
| Version: | 3.3 | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows Vista | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Cabler
Created attachment 67338 [details]
Trace showing error
CoastResourceView is my common nav view
And /none/ of the dependent outside of the platform has changed? (In reply to comment #2) > And /none/ of the dependent outside of the platform has changed? > No - I ran this in M6 again a few times to be sure before filing. As long as M7 has been out I thought it was weird nobody has reported this yet. (In reply to comment #3) > (In reply to comment #2) > > And /none/ of the dependent outside of the platform has changed? > > > > No - I ran this in M6 again a few times to be sure before filing. As long as > M7 has been out I thought it was weird nobody has reported this yet. > More info - tried RC1. Same problem but worse. Now, my thumbnail outline view doesn't even show up - even on close/reopen in the same session. I only get the selector figure, and it works to move the view, but the diagram doesn't show as the thumbnail. Hello, I am a little worried about this one since it would mean either going back to 3.2 or shipping with an M build. I was wondering if anyone has been able to repro this? Also, is there still time to get this in 3.3? thanks, adam The error is a consequence of whatever is killing your GEF editor on startup ... probably the file buffers it is talking to. Could you please reproduce and attach the entire log from your startup sequence (starting eclipse to the "horribly broken" state, without trying anything in text editors)? Also, we're on 3.3RC3 now, which contains numerous fixes over M7. PW Hi Paul, I tried this in RC3, but there is nothing in the log. Here is the current state: Starting in M7, I had to close/reopen the editor to see my connections and diagram in the outline view. In all builds since RC1, I can no longer get the diagram to show up at all in the outline view. I still have to close/reopen the editor to get my connections to appear. Also, I have tried using the same version of GEF with all of these to rule out any GEF changes. Please let me know if I can provide anything to help with this issue. adam (In reply to comment #6) > The error is a consequence of whatever is killing your GEF editor on startup > ... probably the file buffers it is talking to. > > Could you please reproduce and attach the entire log from your startup sequence > (starting eclipse to the "horribly broken" state, without trying anything in > text editors)? > > Also, we're on 3.3RC3 now, which contains numerous fixes over M7. > > PW > Finally - after hours of looking, I found the problem. When I have Antialias turned on, my connections don't get drawn and the thumbnail view won't show my image. Looks like maybe this one belongs to SWT? Again, nothing much has changed in GEF. Hope this helps you guys. Thanx, Adam. So with anti-aliasing on during restart your connections aren't drawn. But if you close and re-open the editor the re-appear. Maybe we're not initializing something on restart or maybe SWT is not. PW That's right. Also, with it on, my Thumbnail never shows. When I turn it off, it appears fine. If it will help, I can try adding AA to one of the GEF examples so you can check it out. (In reply to comment #9) > Thanx, Adam. > > So with anti-aliasing on during restart your connections aren't drawn. But if > you close and re-open the editor the re-appear. > > Maybe we're not initializing something on restart or maybe SWT is not. > > PW > Steve, some strange interactions between GEF, anti-aliasing, and Windows Vista PW > When I have Antialias turned on,
Can you make a small example that shows antialiasing failing? Does it fail only in GEF or in SWT? Can you make a small GEF plugin that fails for you so we have something to try?
Can we get a screenshot? You have a text editor open and a GEF based view? We (SWT) are not GEF users. If you give us something to run or a set of steps that shows the problem, we can get to the bottom of it. Otherwise, we have nothing to work with. Hi Steve, I take it Anthony was replying to me. I'm working on modifying a GEF example that I can send to you. Hopefully, I can reproduce the problem there. adam (In reply to comment #14) > We (SWT) are not GEF users. If you give us something to run or a set of steps > that shows the problem, we can get to the bottom of it. Otherwise, we have > nothing to work with. > Oops. Ok, I'll wait for the code. The Logic Example uses anti-aliasing on the connections. Does that one show the problem? No idea, but someone mentioned modifying a GEF example, and I thought I'd mention it as a starting point. This problem is getting weirder. I have spent some time trying to make one of the examples more like my code, but I still can't repro the problem there. I still have the problem at startup - my diagram doesn't show regardless of the AA flag. However, if I turn AA on, close/reopen the editor, my thumbnail doesn't show. If I close the editor, turn AA off, reopen the editor, the thumbnail shows. I am only changing the one line of code. I have been over my code several times, and I can't figure out what's different. I'll keep trying to see if I can make the example not show the thumbnail with AA on. Created attachment 70907 [details]
No Diagram in outline
This is what the outline shows when restarting with an open editor
Created attachment 70908 [details]
Outline After Reopening editor
I tried with RC4 and added a couple of attachments. I still can't reproduce this with the logic example. 1) When I have AA turned OFF: a) If I start with an open editor, the outline diagram doesn't show b) If I close/reopen the editor, it shows 2) When I have AA turned ON: The diagram doesn't show regardless You said anti-aliased connections were causing the problem, but I don't see any connections in your screenshots. Are you seeing this problem on any platform other than Vista? Are you doing anything special when painting any of your figures? Perhaps using some other advanced GC capabilities? Or updating figures based on update manager or layout notification? Hello, See my responses below: (In reply to comment #24) > You said anti-aliased connections were causing the problem, but I don't see any > connections in your screenshots. > AA does seem to be causing at least some of the problem, but its with the parts, not the connections. Connections still can be shown if enabled in the Outline view. > Are you seeing this problem on any platform other than Vista? > This also happens on XP. > Are you doing anything special when painting any of your figures? Perhaps > using some other advanced GC capabilities? Or updating figures based on update > manager or layout notification? No. But it works normally in <M5. On Microsoft Vista, I tested our GMF based application with a large diagram with anti-aliasing turned on. We use anti-aliasing in GMF for connections, text rendering, rounded rectangles, etc.. I confirmed anti-aliasing works as expected and the thumbnail view works. I shutdown and restarted with the editor open. No errors, nothing indicating anything there is a problem. I can zoom in to clearly see anti-aliasing is applied. I tested with all RC1 drivers: Eclipse RC1, GEF RC1, GMF RC1, EMF RC1, etc. This issue never occurs on Microsoft Windows XP with GMF, we use it every day for development. Thanks for testing Anthony. I wish I could reproduce this with one of the examples so I could send it. I'm prepopulating my diagram with edit parts, and using a custom layout algorithm, but other than that, I can't think of anything else different. I've made the logic example as close as possible, but still can't reproduce it. The main reason I reported it as a bug was because it changed after M5. I'll keep trying to see what I can find. thanks again. adam (In reply to comment #26) > On Microsoft Vista, I tested our GMF based application with a large diagram > with anti-aliasing turned on. We use anti-aliasing in GMF for connections, text > rendering, rounded rectangles, etc.. I confirmed anti-aliasing works as > expected and the thumbnail view works. I shutdown and restarted with the editor > open. No errors, nothing indicating anything there is a problem. I can zoom in > to clearly see anti-aliasing is applied. > > I tested with all RC1 drivers: Eclipse RC1, GEF RC1, GMF RC1, EMF RC1, etc. > > This issue never occurs on Microsoft Windows XP with GMF, we use it every day > for development. > I'm really at a loss on this one. I have tried commenting out any special processing in my editor and still have the same problem. If anyone has an idea how I could debug this, I would appreciate it. It seems that for some reason, the outline view can't show my diagram initially, even though the selector is still there and works. Simply reopening the editor causes it to show properly. thanks, adam (In reply to comment #27) > Thanks for testing Anthony. I wish I could reproduce this with one of the > examples so I could send it. I'm prepopulating my diagram with edit parts, and > using a custom layout algorithm, but other than that, I can't think of anything > else different. I've made the logic example as close as possible, but still > can't reproduce it. The main reason I reported it as a bug was because it > changed after M5. I'll keep trying to see what I can find. > > thanks again. > adam > > (In reply to comment #26) > > On Microsoft Vista, I tested our GMF based application with a large diagram > > with anti-aliasing turned on. We use anti-aliasing in GMF for connections, text > > rendering, rounded rectangles, etc.. I confirmed anti-aliasing works as > > expected and the thumbnail view works. I shutdown and restarted with the editor > > open. No errors, nothing indicating anything there is a problem. I can zoom in > > to clearly see anti-aliasing is applied. > > > > I tested with all RC1 drivers: Eclipse RC1, GEF RC1, GMF RC1, EMF RC1, etc. > > > > This issue never occurs on Microsoft Windows XP with GMF, we use it every day > > for development. > > > Have you played with the Vista theme? No, but I'm seeing this on XP as well. (In reply to comment #29) > Have you played with the Vista theme? > Have you played with the XP theme? No, I haven't played with any theme. Are you suggesting that as a possible fix, or a possible source for the problem? (In reply to comment #31) > Have you played with the XP theme? > (In reply to comment #32) > No, I haven't played with any theme. Are you suggesting that as a possible > fix, or a possible source for the problem? > > (In reply to comment #31) > > Have you played with the XP theme? > > Adam, does the problem still hold (with GEF 3.6) or may be regard this as resolved? (In reply to comment #33) > (In reply to comment #32) > > No, I haven't played with any theme. Are you suggesting that as a possible > > fix, or a possible source for the problem? > > > > (In reply to comment #31) > > > Have you played with the XP theme? > > > > > Adam, does the problem still hold (with GEF 3.6) or may be regard this as > resolved? Resolving as worksforme due to given comments and because there has not been any activity on this bug since 2007. Please reopen in case the issue can still be reproduced with a current GEF/SWT release. |