Bugzilla – Full Text Bug Listing
| Summary: | [preferences] 'Reduced Palette' editor colors not good on Mac and Linux | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Dani Megert <daniel_megert> |
| Component: | Text | Assignee: | Lakshmi P Shanmugam <lshanmug> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | carolynmacleod4, daniel_megert, eclipse, markus.kell.r, Tod_Creasey |
| Version: | 3.3 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | other | ||
| Whiteboard: | stalebug | ||
|
Description
Dani Megert
Using P5 to mark 3.4 candidate as planning didn't start yet. Tod or Markus, would you be willing to provide better color for the Mac? Dani what theme are you using? They are best checked out in a theme that people who are visually impaired would use. Carolyn do you have any suggestions? Adding Kim as she might have some good suggestions. >Dani what theme are you using?
This bug came when people (esp. Markus) tested on Mac and Linux. I tested on WinXP where it looks good.
I don't have any suggestions. I don't know how to see this problem. I have Mac & Linux & Windows in my office, Tod, if you want to drop by and see the problem on machines that are side by side. The problem only appears in Java editors when "Preferences > General > Appearance > Current Theme" is set to "Reduced Palette".
Due to the remappings in jdt.ui's plugin.xml at
<theme
id="org.eclipse.ui.ide.systemDefault">
, e.g.
<colorOverride
id="org.eclipse.jdt.ui.java_doc_default"
value="COLOR_LIST_SELECTION">
, the color of some sections is very light and the text even disappears when selected. This is because the Mac uses a different strategy to draw selections: Selected text is drawn with the text foreground color (not "inverted" like e.g. on Windows) and selection colors are typically very light.
A fix could be to define custom color overrides for the Mac, but AFAICS, this is not supported by the org.eclipse.ui.themes extension point, except maybe through the "colorFactory" attribute. But a colorFactory is not an option, since it forces plug-in loading at startup.
Since this problem only occurs when the user manually selects the "Reduced Palette" theme, I would not spend too much efforts into this and just leave it as it is. Unlike other platforms, the Mac does not have a "High Contrast" mode, so this theme is never selected automatically.
Tod, I suggest to remove this from 3.4 and put in low prio. Agreed? Yes I agree. The Reduced Palette is only important on platforms that have themes that are designed for low vision users. That is currently just Windows although I expect GTK to have something decent in an upcoming release. Kim is it possible to make a theme only show up on a particular platform? If so then we may want to make this win32 and wpf only. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. Lakshmi, can you check on Mac please. |