Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 186222

Summary: [Tool] Extraneous calls to setLocation in SelectionTool
Product: [Tools] GEF Reporter: Adam Cabler <acabler>
Component: GEF-Legacy GEF (MVC)Assignee: gef-inbox <gef-inbox>
Status: RESOLVED INVALID QA Contact:
Severity: normal    
Priority: P3 CC: nyssen
Version: 3.3   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:

Description Adam Cabler CLA 2007-05-09 14:45:19 EDT 
In SelectionTool.updateTargetRequest, request.setLocation(getLocation()) is called, followed by updateHoverRequest().  However, since updateHoverRequest() calls request.setLocation(getLocation()), the first call isn't needed.  Targeting could be sped up by removing any extra calls here.  I'll be happy to suggest a patch if this would be helpful.
Comment 1 Alexander Nyßen CLA 2010-11-08 13:27:41 EST 
Adam, please not that the call of setLocation() is performed on two different request objects. The one in updateTargetRequest is called on the inherited targetRequest field (obtained via getTargetRequest(), stored in the super class), while the one in updateHoverRequest() is called on the local hoverRequest field. As such, the calls are not superfluous and neither of them may be removed.

Resolving as INVALID due to this.