Bugzilla – Full Text Bug Listing
| Summary: | Copyright check should look for third-party copyrights | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | jkubasta |
| Component: | TPTP | Assignee: | Joshua Bowles <jbowles> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P1 | CC: | ewchan, jcayne |
| Version: | unspecified | Keywords: | plan |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 2000 | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
jkubasta
Eugene, would you possibly be able to review this code please? deferral to future with PMC approval How exactly should the plug-ins be flagged, just adding the words "Third Party" before the entry in the FilesWithCopyrights/BadOrMissingCopyrights files or should they be separated in to their own lists. Created attachment 110368 [details]
Adds distinctions for third party files in copyright-check.sh
This will remove third party files from the FilesWithCopyrights and BadOrMissingCopyrights files and lists them in a ThirdPartyFiles file.
Joel could you review the patch.
Created attachment 111125 [details]
Changes Copyright-check.sh to separate third party copyrights into their own file
Disregard the previous patch as it did not search for the copyrights in the correct manner. This patch causes Copyright-check.sh to list files that do not have the words IBM, Intel or Scapa in the copyright statement in a new file "ThirdPartyCopyrights". It also currently ignores source files and certain OS specific files, tell me if that need to be changed.
Created attachment 111835 [details]
Improved version of the copyright checker
Improvement on the old script, shortened grep statements to simplify them and moved the thirdparty checking statement to a better location to remove need to ignore source and native files.
Created attachment 111836 [details]
Adds link on build report page for third party report
(In reply to comment #6) > Created an attachment (id=111835) [details] > Improved version of the copyright checker > > Improvement on the old script, shortened grep statements to simplify them and > moved the thirdparty checking statement to a better location to remove need to > ignore source and native files. > This patch looks okay to me. Patches checked into HEAD. Created attachment 114550 [details]
Adds ThirdpartyCopyright file to upload-driver.sh's list of file to upload
Missed this, files weren't being uploaded to website yet.
Verified and resolving. closing |