Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 185150

Summary: [KeyBindings] Do not allow duplicate key bindings
Product: [Eclipse Project] Platform Reporter: Karsten Becker <eclipse>
Component: UIAssignee: Paul Webster <pwebster>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, markus.kell.r, Tod_Creasey
Version: 3.3Flags: Tod_Creasey: review+
Target Milestone: 3.3 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Show conflict v01
none
Show conflict v02
none
Show conflict v03 none

Description Karsten Becker CLA 2007-05-02 11:28:53 EDT 
In the new keybinding page you can bind a key to an already used one.
i.e. you can bind content assist to ctrl-insert. which is already occupied by copy. There should be at least a warning in some way.
Please take the scope into account such that there is an information when changing a binding for a more specific scope.
Comment 1 Paul Webster CLA 2007-05-08 15:38:42 EDT 
Created attachment 66353 [details]
Show conflict v01

Mark keybinding conflicts that can be determined statically with a '*'

PW
Comment 2 Paul Webster CLA 2007-05-08 19:17:38 EDT 
Created attachment 66383 [details]
Show conflict v02

Show statically conflicting key bindings with '*' character.  When you "fix" the keybinding update the other binding label to remove the "*"

PW
Comment 3 Paul Webster CLA 2007-05-08 19:41:56 EDT 
Created attachment 66386 [details]
Show conflict v03

Same as before, but includes text describing the * and the restore command case.
PW
Comment 4 Karsten Becker CLA 2007-05-09 05:21:06 EDT 
I took a look at the patch and it is nice to have a warning at problematic keybindings. But it would be more obvious to use a warning triangle plus a tooltip than a *. And the label where the current legend is could be better used to show a warning to the user.
Comment 5 Paul Webster CLA 2007-05-09 07:45:10 EDT 
Conflict display could be enhanced in 3.4, but in 3.3 getting new graphics is problemmatic.

Plus as a '*' sorting by the binding column can put all conflicts together.

PW
Comment 6 Paul Webster CLA 2007-05-09 07:55:33 EDT 
*** Bug 185518 has been marked as a duplicate of this bug. ***
Comment 7 Tod Creasey CLA 2007-05-09 15:10:24 EDT 
+1
Comment 8 Paul Webster CLA 2007-05-10 10:47:45 EDT 
In HEAD >20070510
PW
Comment 9 Paul Webster CLA 2007-05-16 10:51:16 EDT 
In I20070516-0010
PW