Bugzilla – Full Text Bug Listing
| Summary: | Changes in cross tab data binding UI | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Aashima Goel <agoel> |
| Component: | BIRT | Assignee: | xingjie he <xhe> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P2 | CC: | cchen, rkanguri, tzhang, whe, yli |
| Version: | 2.2.0 | ||
| Target Milestone: | 2.2.0 RC2 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
| Bug Depends on: | 186500, 186971 | ||
| Bug Blocks: | 167115, 187752 | ||
| Attachments: | |||
|
Description
Aashima Goel
Created attachment 65443 [details]
Cross Tab related Data Binding UI changes in the 'Aggregate On' selection
*** Bug 186287 has been marked as a duplicate of this bug. *** Created attachment 66737 [details]
cross tab aggregation UI
Created attachment 66740 [details]
Add 'Add Aggregation' button in property editor
CrossTab is an ExtendedItem, and it use the cube but not dataset to do column binding.Now the ExtendedItem couldn't get the cube. So we couldn't get the column binding's holder which is the CrossTab. And we couldn't check the ExtendedItem is a CrossTab, GUI should rewrite the binding page and binding dialog in the CrossTab UI Plugin. Are you saying UI cannot get the cubeName from ExtendedItemHandle? But I thought cubeName is returned by ExtendedItemHandle. Can't the UI check if the Report item has dataset then show the data binding UI and if the ExtendedItemhandle has cubeName then show the cube data binding page in property editor? We should get cube by a common method, but not by property to get. Because we couldn't know the property of crosstab about cube, it is defined in the crosstab plugin and only used in the crosstab plugin. Move to rc1 for the 186500, on which this bug depends on, schedules to rc1. Moving back to rc0 for 186500 making as fixed. GUI couldn't get the argment list for a purticular function name. Currently Model does not have any information of those function definitions. Looks like dTe has some problem supporting this for cross tab. So please hold off this change. As per discussion with wenbin, the function name/argument list should be provided by Model team rather than DtE. So is there any problem for model to provide such support? Lin, I think i already agree that model will provide the function list, as indicated in my email. I have put this bug on hold, based on our discussion on last weeks meeting. That DtE cannot support complext java script expression in aggregation builder for cross tab. I have reassigned this bug to Aashima, to revise the UI, so we dont allow user to enter expression but only show the lsit of measures. We need the mockup as soon as quickly.Thanks. Created attachment 68030 [details]
x-Tab aggregation Builder
Updated GUI based on above comments
I have finished the binding page "Add Aggregation" button, Yuejie will do the last part. Fixed Created attachment 69182 [details]
See the current UI, and the expected dialog
UI is not what was proposed. See the attachment
UI is not what was proposed. see attachment(id=68030)in comment #15 Show expression instead of measure name in combo box. Fixed. https://bugs.eclipse.org/bugs/show_bug.cgi?id=130686 https://bugs.eclipse.org/bugs/show_bug.cgi?id=184808 The issue with both the bugs is same the UI is not implemented as mocked up. Please refer to the attachments of this email - Firstly UI should not show groupName, filter and expression ( its redundant ) Example when SUM function is selected there are no parameters Looks like from Xiong's comments model is returning 3 parameters for SUM, i.e expression, group, filter. - We need to fix this, either model should be changed or UI should ignore filter, group and expression in the arguments I am reopening both these bugs *** Bug 189758 has been marked as a duplicate of this bug. *** Created attachment 69364 [details]
changes needed in the dialog
Changes that are required in the dialog has been marked explicitly in the attachment
Remove all parameters of Sum function please. *** Bug 189866 has been marked as a duplicate of this bug. *** remove expr, group and filter arguments. I am using may 31 build. changes have not taken effect completely: 1.expr field is still there. 2. Filter label has to be 'Filter condition'. reopening to be fixed. Please use June 1's build. I just check it code about remove 'expr' argument yesterday. for 'Filter label has to be 'Filter condition'' GUI will check in code today. Thanks close it Created attachment 69814 [details]
something messed up the aggregation builder for crosstabs
X Tab Aggregation Builder is all messed up. Please see the attachment
Reopening based on comment# 30 Fixed already. verified. Build id: v20070604-0630 |