Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 184594

Summary: [Contributions] LegacyActionTools broken on carbon since keybinding delimiter is not "+"
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: minor    
Priority: P5 CC: daniel_megert
Version: 3.3   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard: stalebug
Bug Depends on:    
Bug Blocks: 181830    

Description Markus Keller CLA 2007-04-28 08:21:00 EDT
I20070427-0800

LegacyActionTools is completely broken on carbon, since it hardcodes "+" as key delimiter everywhere, instead of respecting the platform delimiter like e.g NativeKeyFormatter does with its getKeyDelimiter().

One effect of this is that the keybinding for "Open Rename Dialog..."  is not shown in the new in-place rename refactoring support (see attachment 65224 [details] for a screenshot that shows how it works on win32).
Comment 1 Markus Keller CLA 2007-04-28 08:33:30 EDT
Note that the fix for bug 184594 will hide the problem in this scenario.
Comment 2 John Arthorne CLA 2012-07-30 13:27:45 EDT
We no longer build or support Carbon.
Comment 3 Dani Megert CLA 2012-07-31 02:56:20 EDT
(In reply to comment #2)
> We no longer build or support Carbon.

At some point there was only Carbon. If you close a bug just because the OS says Carbon, then this is wrong. You first have to check whether the bug still happens on Cocoa. Looking at the code I'd says this bug is still present.

Other closed Carbon bugs should also be revisted again.

Markus, please close again if I was wrong.
Comment 4 Markus Keller CLA 2012-07-31 04:54:28 EDT
> Note that the fix for bug 184594 will hide the problem in this scenario.
It's bug 184597, actually.

> We no longer build or support Carbon.
This is equally wrong on Cocoa. However, this code rarely used, and I didn't find any any scenario that shows a problem in 3.8 on the Mac, so I'm OK with leaving this at low priority.
Comment 5 Eclipse Genie CLA 2020-03-16 10:33:34 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.