Bugzilla – Full Text Bug Listing
| Summary: | use system filters to define what plugins to be downloaded through Update Manager | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Valentina Popescu <popescu> |
| Component: | TPTP | Assignee: | Joel Cayne <jcayne> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | P1 | CC: | jkubasta, nmehrega, sluiman, stoian |
| Version: | unspecified | Keywords: | plan |
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | closed460 | ||
|
Description
Valentina Popescu
Correction; Eclipse-PlatformFilter is not used in org.eclipse.tptp.platform.ac.linux_ia32 plugin, but in the old org.eclipse.hyades.execution(.linux, etc ) plugins. The Eclipse-PlatformFilter options might be also used in the new IAC execution plugins but since I don't have an Intel build of those plugins I can't verify it. I did check on the feature importing them though ( org.eclipse.tptp.platform.core ) and it is not using the os filter attributes One last comment; the old execution plugins in the feature.xml file did have the os filters specified.
They have been replaced with the new IAC execution plugins on 04/11 ( revision 1.60 of the feature plugin ) but the os specification has been removed and not being added back. This looks like a regression introduced in 4.4 that needs to be fixed in 4.4.
Old plugin import :
<plugin
id="org.eclipse.hyades.execution.win32.x86"
os="win32"
arch="x86"
download-size="0"
install-size="0"
version="0.0.0"
fragment="true"/>
New plugin import, missing system properties :
<plugin
id="org.eclipse.tptp.platform.ac.win_ia32"
download-size="0"
install-size="0"
version="0.0.0"/>
Sorin has added the os and arch filters. Reopenning bug to investigate a build issue related to this change. The plugins with os and arch filters are not packaged in the zip files. Not containable in 4.4 Not containable in 4.4 This defect is very critical to resolve in the current release. Is it understood how to enable teh supprot requested, or is there still design required and perhaps unknown dependancies to resolve? TPTP provides one zip containing all the plug-ins for every platform. To do this, I am looking into using groupConfigurations to maintain this format while providing the requested functionality. Using group configurations, the same behaviour occurs as described in comment #4. I have added OS and Architecture filters to the manifest.mf in the plug-ins: org.eclipse.tptp.platform.ac.linux_em64t org.eclipse.tptp.platform.ac.linux_ia32 org.eclipse.tptp.platform.ac.linux_ipf org.eclipse.tptp.platform.ac.win_em64t org.eclipse.tptp.platform.ac.win_ia32 org.eclipse.tptp.platform.ac.win_ipf The filters have also been added to the entries in the feature.xml of the containing feature org.eclipse.tptp.platform.core. Downloading the driver from the website, such as the All TPTP Plug-ins runtime, contains all platform plug-ins but only enables the platform specific org.eclipse.tptp.platform.ac plug-in in the workbench. Verified by going to Help -> About Eclipse SDK -> Plug-in Details -> sorting the list by Plug-in ID and looking for the plug-in. Downloading the driver from the update site downloads and installs only the platform specific org.eclipse.tptp.platform.ac plug-in. Verified by creating a sample update site, selecting only the platform project and performing the above check in the workbench. Also checked the eclipse/plugins folder to verify the plug-ins downloaded. Tested on Windows and Linux IA32 platforms. Based on the testing, (1) from comment 1 does not appear to be required, so only (2) was performed. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |