Bugzilla – Full Text Bug Listing
| Summary: | [QuickAccess] Polish QuickAccess dialog | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Boris Bokowski <bokowski> | ||||||||
| Component: | UI | Assignee: | Boris Bokowski <bokowski> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | tom.schindl | ||||||||
| Version: | 3.3 | Flags: | pwebster:
review+
|
||||||||
| Target Milestone: | 3.3 RC1 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | 172614, 181189, 184045 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Boris Bokowski
Created attachment 64658 [details]
work in progress
Created attachment 64813 [details]
work in progress
now with owner draw
Added tooltips, fixed an off-by-one error, set image and text for platforms without owner draw, renamed package, switched to CTRL-3 as the key binding. What's left: - profiling with large data sets - selecting best match, not just the first match - showing all matches - showing more than 5 per category if the total number is less than 20 - more information for preference pages (In reply to comment #3) Done: > - selecting best match, not just the first match > - showing all matches > - showing more than 5 per category if the total number is less than 20 > - more information for preference pages What's left: profiling with all plug-ins of the Europa release train. Moving to RC1. We should try to remove the workaround for bug 184045. Created attachment 67141 [details]
patch to add busy cursor while opening
Testing with all of Europa, there is a noticeable delay (about 2.5 seconds on my machine) when the dialog is first brought up. I profiled what was happening but couldn't find anything to optimize. The reason are parameterized commmands for opening views, preference pages, etc which will read the various registries if they haven't been read already. Unfortunately, we need to build the list of commands eagerly because their enablement state changes once we have opened the shell for the dialog.
So for now, I propose to show a busy cursor while opening the dialog.
Paul, could you review the busy cursor patch for me? Thanks. +1, if you could delete this on the way in: providers[0] = new PreviousPicksProvider(); PW Patch released after deleting the line (thanks Paul!) >20070515. Verified using I20070517-1700 on Windows XP. |