Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 18357

Summary: [ActionSets] Action set ordering is not stable
Product: [Eclipse Project] Platform Reporter: Randy Giffen <Randy_Giffen>
Component: UIAssignee: Simon Arsenault <simon_arsenault>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P2 CC: n.a.edgar
Version: 2.0   
Target Milestone: 2.1 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Randy Giffen CLA 2002-05-30 14:34:39 EDT 
20020528 (also in 20020521)

1) Use customize perspective dialog to turn on debug action set
2) Check Run menu, External tools is at the top
3) Turn off External tools action set
4) Check run menu
5) Turn on External tools action set
6) Note External tools is at the bottom
Comment 1 Nick Edgar CLA 2002-05-30 15:13:06 EDT 
We try to process them in order of id when initially added, but this does not 
get maintained for incremental updates.
Comment 2 Nick Edgar CLA 2002-11-20 12:06:16 EST 
Should fix for 2.1, in conjunction with bug 16282.
Comment 3 Simon Arsenault CLA 2002-12-11 14:43:01 EST 
Changed PluginActionSetBuilder (and a little PluginActionBuilder) to do the 
following:

1) Menu group markers/separators are sorted based on the action set id to keep 
these group in a consistent order. We use to just add to the end of the menu.

2) When scanning thru the actions of a menu group, the search is terminated if 
another group is found. Therefore the action will be added to the end of the 
group. It was possible beforehand to scan past the end of the group and end up 
adding an action into a different group.

Plugin developers can now depend on the action set id to properly order their 
actions. We know this is not ideal but is sufficient for the moment until we 
can properly address bug 16282
Comment 4 Nick Edgar CLA 2002-12-16 16:41:21 EST 
Verified in I20021216.