Bugzilla – Full Text Bug Listing
| Summary: | [implementation] SynchronizedDocument should use lock object when accessing line tracker | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | Text | Assignee: | Dani Megert <daniel_megert> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | b.muskalla, benno.baumgartner, christian.dietrich.opensource, francisu, loskutov, markus.kell.r, michschn, mik.kersten, steffen.pingel, thatnitind, utilisateur_768, zverinski | ||||
| Version: | 3.3 | ||||||
| Target Milestone: | 3.5 M1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=474373 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Dani Megert
We have to do this early 3.4 to gather feedback (deadlocks, performance). *** Bug 218725 has been marked as a duplicate of this bug. *** >We have to do this early 3.4 to gather feedback (deadlocks, performance).
Indeed - but mussed it. Let's try for 3.5.
*** Bug 230933 has been marked as a duplicate of this bug. *** *** Bug 233907 has been marked as a duplicate of this bug. *** *** Bug 236967 has been marked as a duplicate of this bug. *** *** Bug 236405 has been marked as a duplicate of this bug. *** The following methods need to be added to the SynchronizableDocument: getLineInformationOfOffset getLineInformationOfOffset getLineOfOffset getLineDelimiter getDefaultLineDelimiter computePartitioning startRewriteSessionOnPartitioners stopRewriteSessionOnPartitioners *** Bug 226652 has been marked as a duplicate of this bug. *** Created attachment 104869 [details]
Fix
After committing that patch we have to watch for performance regression and deadlocks.
*** Bug 237443 has been marked as a duplicate of this bug. *** Fixed in HEAD. Available in builds > N20080619-2000. *** Bug 253878 has been marked as a duplicate of this bug. *** Just got this stack on shutdown of Eclipse 3.8 (the bug is supposed to be fixed in 3.5?). Xtext editor is involved however, not sure if the problem on the xtext side or not:
Exception in thread "Thread-2515" java.lang.NullPointerException
at org.eclipse.jface.text.AbstractLineTracker.flushRewriteSession(AbstractLineTracker.java:293)
at org.eclipse.jface.text.AbstractLineTracker.checkRewriteSession(AbstractLineTracker.java:315)
at org.eclipse.jface.text.AbstractLineTracker.getLineNumberOfOffset(AbstractLineTracker.java:160)
at org.eclipse.jface.text.AbstractDocument.getLineOfOffset(AbstractDocument.java:915)
at org.eclipse.xtext.ui.editor.folding.DefaultFoldedPosition.computeProjectionRegions(DefaultFoldedPosition.java:70)
at org.eclipse.jface.text.source.projection.ProjectionViewer.computeCollapsedRegions(ProjectionViewer.java:1132)
at org.eclipse.jface.text.source.projection.ProjectionSummary.createSummaries(ProjectionSummary.java:208)
at org.eclipse.jface.text.source.projection.ProjectionSummary.internalUpdateSummaries(ProjectionSummary.java:157)
at org.eclipse.jface.text.source.projection.ProjectionSummary.access$3(ProjectionSummary.java:147)
at org.eclipse.jface.text.source.projection.ProjectionSummary$Summarizer.run(ProjectionSummary.java:72)
(In reply to Andrey Loskutov from comment #14) > (the bug is supposed to be fixed in 3.5?). Yes. @andrey. have you seen this issue again. see https://bugs.eclipse.org/bugs/show_bug.cgi?id=474373 as well (In reply to Christian Dietrich from comment #16) > @andrey. have you seen this issue again. see > https://bugs.eclipse.org/bugs/show_bug.cgi?id=474373 as well No, since we moved to 4.6. |