Bugzilla – Full Text Bug Listing
| Summary: | TPTP Project Hygiene: Remove all references to com.ibm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | jkubasta | ||||||
| Component: | TPTP | Assignee: | Kathy Chan <kathy> | ||||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||||
| Severity: | critical | ||||||||
| Priority: | P2 | CC: | analexee, apnan, guru.nagarajan, hkyleung, jcayne, lizdancy, paulslau, popescu, samwai, sgutz, slavescu, sluiman, smith | ||||||
| Version: | unspecified | Keywords: | plan | ||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 2000 | ||||||||
| Whiteboard: | closed471 | ||||||||
| Attachments: |
|
||||||||
|
Description
jkubasta
Test project verified and fixed (org.eclipse.hyades.test.doc.user\ref\rsupported-test-execution-service-properties.htm). Only references to com.ibm.icu.* remain. Note, there was already a round of updates in 4.0 - 4.1 (see defects 101690 - 101705). if the ICU package is still in the IBM name space and that is what is used publicly fine, but this is in effect an IP issue, and there is a zero tolerance policy on this. (In reply to comment #2) > if the ICU package is still in the IBM name space and that is what is used > publicly fine, but this is in effect an IP issue, and there is a zero tolerance > policy on this. > This is the package structure as provided in the com.ibm.icu_3.6.0.20061215.jar by Eclipse. The issue here is not the one ICU ;-) but there are apparently several strings through out TPTP that need to be cleaned up. Updated org.eclipse.hyades.sdb\schema\symptomEditHandler.exsd, removed references to com.ibm. Updated org.eclipse.hyades.probekit.src.org.eclipse.tptp.platform.probekit.util.ProbekitDebugConfig.java to remove comment referencing *.com.ibm.* References needing investigating/correcting: (1) org.eclipse.hyades.resources.database.* which contains references to com.ibm.db2*.* (2) org.eclipse.tptp.platform.analysis.static.engine.schema.* which contain references to com.ibm.r2a.engine2.* (3) org.eclipse.tptp.platform.analysis.static.engine.ui.src.org.eclipse.tptp.platform.analysis.engine.ui.engineview.* - multiple comments referencing com.ibm.r2a.* (4)org.eclipse.tptp.platform.analysis.static.util.* - multiple comments referencing com.ibm.r2a.* (5) org.eclipse.tptp.platform.collection.framework.* - multiple references to com.ibm.ws.performance.* (6) org.eclipse.tptp.platform.llc.* contains references to *com.ibm.ra.* (7) org.eclipse.tptp.platform.models.src-hierarchy.org.eclipse.hyades.loaders.* contains reference to com.ibm.etools.* and com.ibm.jvm.* (8) org.eclipse.tptp.platform.probekit.launch.* contains references to com.ibm.rational.* (9) org.eclipse.tptp.platform.releng.tools.* contains references to com.ibm.* Removed com.ibm references from the following files: org.eclipse.tptp.symptom.internal.presentation.BaseDetailsPage.java org.eclipse.tptp.symptom.internal.presentation.SymptomCatalogDetails.java org.eclipse.tptp.symptom.internal.presentation.SymptomMasterDetailsBlock.java Steve, can you take a look at the Static Analysis plug-ins in https://bugs.eclipse.org/bugs/show_bug.cgi?id=182662#c7? Regarding the static analysis components. The code in question has been obsolete for over 2 years and hasn't shipped in a TPTP release since before 4.0 (if ever). I'm not planning to fix these. *** Bug 114702 has been marked as a duplicate of this bug. *** Samson has looked at comment 7, item 5 and says that he can remove all comments which reference "com.ibm" but there is code which loads the "com.ibm" classes explicitly. This code is part of the core functionality of the thread analyzer so removing it might cause the whole plugin to stop working properly. Is there a plan to remove this thread analyzer plugin? Is anyone using it? Samson believes that no bug was ever opened against that component. Marius, please look at items 1 and 7 in comment 7 Valentina, would you please look at items 6 and 8? Anyone know who owns releng (it is not referenced in the Matrix)? (8) org.eclipse.tptp.platform.probekit.launch.* contains references to com.ibm.rational.* - fixed in i3 (6) org.eclipse.tptp.platform.llc.* contains references to *com.ibm.ra.* This is a tech preview function; the com.ibm references are used by the probe classes so to replace the com.ibm references, the native code must be recompiled. The llc runtime will be eventually replaced by a new proposal and this will also fix the com.ibm references Item 7 is fixed in i3 ; the only remaining com.ibm references are from the com.ibm.icu* packages Marius, can you please address item 1? Thanks. (In reply to comment #17) > Marius, can you please address item 1? Thanks. > I only removed the comments, the other cases are for Cloudscape embedded and with IBM DB2 JCC driver with which we support in TPTP, I cannot remove them. (In reply to comment #18) > (In reply to comment #17) > > Marius, can you please address item 1? Thanks. > > > I only removed the comments, the other cases are for Cloudscape embedded and > with IBM DB2 JCC driver with which we support in TPTP, I cannot remove them. It is now too late to fix in 4.4 but the various database vendors support should be supported by extension. I believe we only "ship" code that binds to open source run times. The exception would be if the open source in fact has these package names. (In reply to comment #12) > Samson has looked at comment 7, item 5 and says that he can remove all > comments which reference "com.ibm" but there is code > which loads the "com.ibm" classes explicitly. This code is part of the core > functionality of the thread analyzer so removing it might cause the whole > plugin to stop working properly. > Is there a plan to remove this thread analyzer plugin? Is anyone using it? > Samson believes that no bug was ever opened against that component. There was a donation of code to do thread analysis, but we did not ever include it in a driver since there was a thread analyser being developed from fresh along with the JVMTI agent. We should only be building and shipping this new thread profiler. So I asked Sorin about whether we build the following: org.eclipse.tptp.platform.analysis.static.engine.schema.* org.eclipse.tptp.platform.analysis.static.util.* org.eclipse.tptp.platform.collection.framework.* org.eclipse.tptp.platform.models.src-hierarchy.org.eclipse.hyades.loaders.* We build all of the above except: org.eclipse.tptp.platform.analysis.static.util We also do NOT build: org.eclipse.tptp.platform.analysis.static.engine.ui.src.org.eclipse.tptp.platform.analysis.engine.ui.engineview.* (In reply to comment #21) > So I asked Sorin about whether we build the following: > org.eclipse.tptp.platform.analysis.static.engine.schema.* > org.eclipse.tptp.platform.analysis.static.util.* > org.eclipse.tptp.platform.collection.framework.* > org.eclipse.tptp.platform.models.src-hierarchy.org.eclipse.hyades.loaders.* > We build all of the above except: > org.eclipse.tptp.platform.analysis.static.util Steve, please work with Sorin to ensure we are not building or packaging any unwanted code. Created attachment 70785 [details]
org.eclipse.tptp.platform.analysis.static.engine.ui/src/org/eclipse/tptp/platform/analysis/engine/ui/engineview
References needing investigating/correcting: (1) org.eclipse.hyades.resources.database.* which contains references to com.ibm.db2*.* - DEFER TO FUTURE (2) org.eclipse.tptp.platform.analysis.static.engine/schema.* which contain references to com.ibm.r2a.engine2.* - OPEN (3) org.eclipse.tptp.platform.analysis.static.engine.ui/src/org/eclipse/tptp/platform/analysis/engine/ui/engineview.* - multiple comments referencing com.ibm.r2a.* - NOT BEING BUILT; PATCH ATTACHED REMOVING ALL @SEE LINES CONTAINING com.ibm.r2a. PMC'S CHOICE AS TO WHETHER TO APPLY THE PATCH, REMOVE PLUGIN FROM CVS, OR LEAVE AS IS (4)org.eclipse.tptp.platform.analysis.static.util.* - multiple comments referencing com.ibm.r2a.* - FIXED (5) org.eclipse.tptp.platform.collection.framework.* - multiple references to com.ibm.ws.performance.* - OPEN; SEE COMMENT 20 (6) org.eclipse.tptp.platform.llc.* contains references to *com.ibm.ra.* - OPEN; SEE COMMENT 15 (7) org.eclipse.tptp.platform.models.src-hierarchy.org.eclipse.hyades.loaders.* contains reference to com.ibm.etools.* and com.ibm.jvm.* - FIXED (8) org.eclipse.tptp.platform.probekit.launch.* contains references to com.ibm.rational.* - */internal/config/ProbekitProfilingType.java CONTAINS TWO REFERENCES STILL TO com.ibm.rational (9) org.eclipse.tptp.platform.releng.tools.* contains references to com.ibm.* - THREE REFERENCES REMAIN (10) org.eclipse.hyades.execution/src-local - TWO REFERENCES (11) org.eclipse.hyades.probekit - MULTIPLE REFERENCES TO com.ibm.rational (12) org.eclipse.hyades.releng.builder/master/bash - TWO REFERENCES TO com.ibm.featuredoc (13) org.eclipse.tptp.platform.analysis.core.ui.doc - REFERENCE TO com.ibm.sse in .project file (14) org.eclipse.tptp.platform.doc.isv - REFERENCE TO com.ibm.sse in .project file (15) org.eclipse.tptp.platform.doc.user - REFERENCE TO com.ibm.sse in .project file; REFERENCE TO com.ibm.etools in .project file (16) org.eclipse.tptp.platform.log.doc.user - REFERENCE TO com.ibm.sse in .project file; REFERENCE TO com.ibm.etools in .project file Reference (8) comes from the JVMPI probekit source code and both references are in commented out code. I think we can safely remove them. Created attachment 71048 [details]
ProbekitProfilingType.java patch
Liz, please review
Hubert, would you please do me a favour and check to see if we can get rid of any of the com.ibm references in: 9)org.eclipse.tptp.platform.releng.tools.* contains references to com.ibm.* - THREE REFERENCES REMAIN 12) org.eclipse.hyades.releng.builder/master/bash - TWO REFERENCES TO com.ibm.featuredoc (13) org.eclipse.tptp.platform.analysis.core.ui.doc - REFERENCE TO com.ibm.sse in .project file (14) org.eclipse.tptp.platform.doc.isv - REFERENCE TO com.ibm.sse in .project file (15) org.eclipse.tptp.platform.doc.user - REFERENCE TO com.ibm.sse in .project file; REFERENCE TO com.ibm.etools in .project file (16) org.eclipse.tptp.platform.log.doc.user - REFERENCE TO com.ibm.sse in .project file; REFERENCE TO com.ibm.etools in .project file (In reply to comment #27) > Created an attachment (id=71048) [details] > ProbekitProfilingType.java patch > Liz, please review The patch looks good. Patch for comment (8) committed to Head with PMC approval As of 3/18/2008, the following references need to be removed from the Platform project: 1) org.eclipse.hyades.probekit/src-native/*: contains multiple references to com.ibm.rational.pd.probekit* 2) org.eclipse.hyades.releng.builder contains references to com.ibm.featuredoc 3) org.eclipse.hyades.resources.database conatins references to com.ibm.db2j.jdbc.DB2jDriver 4) org.eclipse.tptp.platform.analysis.core.ui.doc - reference to com.ibm.sse.model.structurebuilder in .project file 5) org.eclipse.tptp.platform.analysis.static.* - Steve Gutz has no plan to address as per comment 10 in this bug 6) org.eclipse.tptp.platform.collection.framework contains references to com.ibm.ws.performance.threadanalyzer.*, com.ibm.ejs.*, com.ibm.ws.* 7) org.eclipse.tptp.platform.llc.* contains references to *com.ibm.ra.* and these will not be fixed as per comment 15 in this bug 8) org.eclipse.tptp.platform.doc.isv contains references to com.ibm.sse.model.structurebuilder 9) org.eclipse.tptp.platform.doc.user contains references to com.ibm.sse.model.structurebuilder and com.ibm.etools.webtools.* 10) org.eclipse.tptp.platform.log.doc.user contains references to com.ibm.sse.model.structurebuilder and com.ibm.etools.webtools.* 11) org.eclipse.tptp.platform.releng.tools contains references to ibm.com.* where * equals DepCalculator, FeatureDoc or VersionTable Monitoring Project: 1) org.eclipse.hyades.logging.parsers contains numerous references to com.ibm.logging.icl.BasicLogTestCase 2) org.eclipse.hyades.sdb.new contains reference to com.ibm.etools.symptom.edit 3) org.eclipse.tptp.monitoring.la.core contains references to com.ibm.etools.logging.* Test project is clean (only references to com.ibm.icu) Trace Project: 1) org.eclipse.tptp.trace.arm contains reference to com.ibm.tivoli.transperf.arm4.* and references to com.ibm.CORBA.* 2) org.eclipse.tptp.trace.memory.ui contains reference to com.ibm.oti.vm (In reply to comment #31) > 2) org.eclipse.hyades.releng.builder contains references to com.ibm.featuredoc > > 11) org.eclipse.tptp.platform.releng.tools contains references to ibm.com.* > where * equals DepCalculator, FeatureDoc or VersionTable Packages updated to org.eclipse.tptp.platform.releng.tools. Deferring to future with PMC approval Mass update of P1 enhancements and defects targetted to future to P2. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. I am not sure this is really an enhancement -- more of a critical defect in my opinion. Please reconsider. Kathy, please triage. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. Since this defect is more than 2 years old, it may be no longer relevant. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this defect is resolved as WONTFIX. If this defect is still relevant and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |