Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 182027

Summary: BIRT Designer - Enhancments to XML dataset edtior UI
Product: [Tools] Data Tools Reporter: Rima Kanguri <rkanguri>
Component: EnablementAssignee: Xiaoxiao Wu <xwu>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: lzhu, wenfeng.fwd, whe
Version: 1.5Keywords: plan
Target Milestone: 1.6M5   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
XMl Dataset Editor UI based on discussion above none

Description Rima Kanguri CLA 2007-04-11 17:03:56 EDT
The XML datat set UI needs some improvemements. This is based on user feedback.
I am logging this bug is to track the UI enhancments.
Comment 1 Rima Kanguri CLA 2007-04-11 17:05:02 EDT
Following are some suggestions i have.
 

A) New XML Data set wizard

            - The category pages will change and be consistent with  will be same as the changes below

            - We need to revise the Preview input dialog.

 

B) Edit XML Data set

1)       We need to remove the category XML Dataset, and fit it in Preview Results some how, it doesn’t fit in as a top level category.

-          I think the properties under current category XML dataset should be under Preview tab. As these are really preview properties.

 

2)       Table Mapping 

-          The XML file browser view should be enhanced to have icons for each type of node ( u might want to come up with some icons here)

-          When user clicks on the “>”  button, the input dialog should give 3 choices

                                                               i.      Absolute path to << element selected>>

                                                             ii.      All occurrences of << element selected >>

                                                            iii.      Custom ( For this case user can enter XPath expression )

 

-          The right hand side of the dialog should allow user to change the choices selected above.

Note the XPath expression is shown only for choice iii.

 

3)       Column Mapping

-          Get rid of the preview results 

-          Same set of enhancements to the XML file viewer ( icons etc )

-          In the XML file viewer you should highlight the node selected

-          Also all the other nodes other than the node highlighted should be collapsed

-          Get rid of the yellow highlighting

-          When the user clicks the “>” button, the input dialog should give the 3 same choices as in (2) above

-          Change the right hand side of dialog to use standard “Edit”, “delete”, “Up”, “Down” buttons 

Comment 2 Rima Kanguri CLA 2007-04-11 17:08:36 EDT
Please ignore the previous comments. 

Following are some of the UI suggestions.

A) New XML Data set wizard
- The categories will be consistent with the changes in B)
- We need to remove the Preview input dialog.
 

B) Edit XML Data set

1)  Remove the category XML Dataset, and fit it in Preview Results some how, it doesn’t fit in as a top level category.
I think the properties under current category XML dataset should be under Preview tab. As these are really preview properties.

2)       Table Mapping 
The XML file browser view should be enhanced to have icons for each type of node ( u might want to come up with some icons here)
- When user clicks on the “>”  button, the input dialog should give 3 choices
   i.      Absolute path to << element selected>>
   ii.      All occurrences of << element selected >>
   iii.      Custom ( For this case user can enter XPath expression )

- The right hand side of the dialog should allow user to change the choices selected above.
Note the XPath expression is shown only for choice iii.

3) Column Mapping
- Get rid of the preview results 
- Same set of enhancements to the XML file viewer ( icons etc )
- In the XML file viewer you should highlight the node selected
- Also all the other nodes other than the node highlighted should be collapsed
- Get rid of the yellow highlighting
- When the user clicks the “>” button, the input dialog should give the 3 same choices as in (2) above
- Change the right hand side of dialog to use standard “Edit”, “delete”, “Up”, “Down” buttons 

Comment 3 Aashima Goel CLA 2007-04-30 17:54:35 EDT
Created attachment 65438 [details]
XMl Dataset Editor UI based on discussion above
Comment 4 Lin Zhu CLA 2007-05-24 21:20:53 EDT
XML UI belongs to DtP project, which is also in release candidate cycle. We would like to defer this bug to post 2.2.0.
Comment 5 Ivan Zhu CLA 2007-10-12 05:55:10 EDT
Rima,

For the bug 182027:  BIRT Designer - Enhancments to XML dataset edtior UI, I have some questions:

1�A	In page 6 of attached file about this bug, �gAdd button�h in note 3, does it mean  �gEdit button�h?
2�A	In page 9, what�fs the meaning about the first �gpreview setting�h in the left tree in the picture?
And what�fs the meaning about the second one in the node �gpreview�h? Does it mean �gpreview results�h?
3�A	In comment 2# of this bug, does the XML file viewer means the GUI in page 7?
If yes, the note says: clicking the Preview button will show the preview in given space, what�fs the meaning �gin given space�h? Is it referred the file in file browser?  

4�A And in comment 2#,
It says �g- In the XML file viewer you should highlight the node selected
- Also all the other nodes other than the node highlighted should be collapsed
- Get rid of the yellow highlighting�h

It seems that in the GUI in page 7, cannot find any node.
Comment 6 Xiaoxiao Wu CLA 2007-12-28 23:59:55 EST
According to the spec of the "XML Dataset Editor UI" enhancement, some modification has been done mainly described as follows:

1. Have changed the title of some pages in XML Dataset Editor UI.

2. Have changed the several pages' style of XML Dataset Editor UI mainly about the layout and buttons' style.

3. Have made the icons for each kind of XML tree node.

4. Have added a new button ">>" in column mapping page, which allows the user to add multiple XML tree elements to column mapping table at one time.

5. Have discarded sample data preview table and added a preview button instead. The previewed sample data will be displayed in a popped-up dialog by pressing "Show sample data" button.

6. Have added a new button "edit" to the right of column mapping table, which allows the user to edit a selected column mapping element. The user, however, cannot modify a table cell directly on the table now. Instead he can edit some element by double clicking it on column mapping table. 

7. Have modified revalent MANIFEST.MF as well.

Mark this bug as fixed.
Comment 7 Brian Fitzpatrick CLA 2008-07-01 17:37:57 EDT
Closing bugs