Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 181077

Summary:	[rename] CTRL+S during new inline refactoring does not perform the refactor
Product:	[Eclipse Project] JDT	Reporter:	Randy Hudson <hudsonr>
Component:	UI	Assignee:	Markus Keller <markus.kell.r>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.3
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description Randy Hudson

2007-04-04 17:51:30 EDT

1) ALT+SHIFT+R to invoke new refactoring inline.
2a)After editing the name, CTRL+S to save the editor
OR
2b)Move the caret to somewhere else.

The refactoring does not occur, which is not obvious to the user. Only a local "Rename in File" is happening as you type. In 2a) The refactor popup is still visible - If the user presses "cancel" (ESC), the edit is not reverted.

If the refactoring popup is visible, it should be *impossible* to do something that is not listed as a possible outcome. When the popup is hidden, the user must be prompted to perform one of the 4 listed actions, not some 5th action (Rename in File) which is not even listed as an option. Save should not be enabled while the popup is visible, or could be interpreted as ENTER.

The risk to the User is that subclasses are left with methods that no longer override the superclass, which can be very hard to debug in that absence of compile errors.

Comment 1 Eclipse Genie

2019-02-12 00:23:00 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.