Bugzilla – Full Text Bug Listing
| Summary: | [Presentations] R33 presentation classes: do we still need? | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Kevin McGuire <Kevin_McGuire> |
| Component: | UI | Assignee: | Kevin McGuire <Kevin_McGuire> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Tod_Creasey |
| Version: | 3.3 | ||
| Target Milestone: | 3.4 M3 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | 122639 | ||
| Bug Blocks: | |||
|
Description
Kevin McGuire
I did a bit of a scan and it looks like we're set to remove the 33 presentation *except*: 1. DefaultTabFolder is different but I think its just fix done in one and not copied to the other. 2. WorkbenchPresentationFactory_33 overrides createViewPresentation() with a wad of code. This needs to be examined. Comppares are presentations.R33 vs. presentations.defaultpresentation unless otherwise noted. DefaultSimpleTabListener 1.2 vs. 1.4 - No changes (other than copyright slam and package) DefaultTabFolder 1.4 vs. 1.22 - There are changes between the two but I don't think its presentation specific, I think its a bug fixed in one and not the other. - The changes are around updateColors() now taking as argument the activation state (added in the 3.3. presentation). DefaultTabFolderColors 1.2 vs. 1.4 - No changes (other than copyright slam and package) DefaultTabItem.java 1.4 vs. 1.16 - No changes (other than copyright slam and package) DefaultThemeListener 1.2 vs. 1.4 - No changes (other than copyright slam and package) org.eclipse.ui.internal.presentations.PaneFolder.java 1.40 org.eclipse.ui.internal.presentations.r33.PaneFolder.java 1.5 - No changes (other than copyright slam and package) org.eclipse.ui.internal.presentations.PaneFolderButtonListener.java 1.5 org.eclipse.ui.internal.presentations.r33.PaneFolderButtonListener.java 1.3 - No changes (other than copyright slam and package) org.eclipse.ui.internal.presentations.r33.WorkbenchPresentationFactory_33.java 1.3 - This extends org.eclipse.ui.presentations.WorkbenchPresentationFactory.java so there is nothing to compare it to. It overrides createViewPresentation() doing a lot of stuff which someone would need to have a look at. Note that the R33 presentation is still the current, its just now named Default. Further reason to remove: - DefaultThemeListener in r33 gets called for view updates - but DefaultThemeListener in defaultpresentation gets called for editor updates Argh! We need to fix this in 3.4. Once again I was burned by the fact that we have two copies of Pane Folder, one of which view stacks go through and one of which editor stacks go through! I'm happy to help out on this one as it'd give me more understanding of the presentation framework. This bug irritates me and I've done a lot of the groundwork already... anybody have any objections to me taking it? Committed for I200711013-0800. The R33 package and classes were deleted. The default presentation code now implements the default presentation (go figure). One change was needed to support old R30 presentation behavior (PaneFolder layout() hides icons for non focus tabs). We grew a internal.presenstations.classic package to hold this and any other changes we wish to preserve for 3.0. Verified in 3.3 M4 that the R33 presentation classes are no longer in the jars in the install. And the default presentation seems to work fine. |