Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 180280

Summary: Unmovable rows in Datapool Editor
Product: z_Archived Reporter: Alex Bernstein <alexberns>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: jkubasta, nedelec, paulslau
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch. none

Description Alex Bernstein CLA 2007-03-30 15:19:57 EDT
We were able to move rows in a data pool.
Now there is no mechanism to move rows.The row number was editable so we could move it after row0,after row 1 etc.
This was helpful while testing,not sure why this feature is not available now.
Comment 1 Nédélec Patrick CLA 2007-04-03 04:20:17 EDT
*** Bug 180577 has been marked as a duplicate of this bug. ***
Comment 2 Jerome Gout CLA 2007-04-03 05:20:41 EDT
This does not seem to be a defect but rather an enhancement.
You are describing a missing feature of the datapool editor.
Comment 3 Joe Toomey CLA 2007-06-06 10:02:07 EDT
Alex seems to imply that this feature once existed but has been removed.  Alex, did this feature exist in TPTP, or in a different datapool editor?

Targetting to future for now -- based on discussion with submitter, we will decide whether this is a 4.5 defect, or an enhancement to be weighed with other enhancement requests.
Comment 4 Alex Bernstein CLA 2007-06-06 10:14:34 EDT
The defect was submitted by an end user/tester. His description claims that that functionality was available in RPT 612 (with whatever version of Hyades) and is not available anymore.
Comment 5 Joe Toomey CLA 2007-06-06 10:32:26 EDT
Thanks for the clarification, Alex.  This would imply that Hyades 3.3 supported this capability, and we can easily validate that.  If that is true, then I suggest we should move this back to a defect and consider it for 4.5.
Comment 6 Paul Slauenwhite CLA 2007-07-05 10:12:20 EDT
After confirming in Hyades 3.3.0, this is a regression.  in Hyades 3.3.0, double-clicking on the row number cell opens a dialog allowing the user to select the position of the row, similar to column repositioning.

Jerome/Patrick: Please provide a sizing for this defect.
Comment 7 Paul Slauenwhite CLA 2007-11-07 06:33:05 EST
Bulk update of the target field to reflect the change in iteration numbers.
Comment 8 Paul Slauenwhite CLA 2008-01-07 09:13:13 EST
Deferring to I6.
Comment 9 Paul Slauenwhite CLA 2008-02-14 06:34:35 EST
(In reply to comment #6)
> After confirming in Hyades 3.3.0, this is a regression.  in Hyades 3.3.0,
> double-clicking on the row number cell opens a dialog allowing the user to
> select the position of the row, similar to column repositioning.

See http://www.eclipse.org/tptp/home/downloads/drops/3.3.0.html to download Haydes 3.3.0.
Comment 10 Paul Slauenwhite CLA 2008-02-25 13:54:15 EST
Hi Paul K.  
This defect is required for 4.5 I6 and development ends on March 14 (3 weeks).  Will you be able to complete this defect by that date?
Comment 11 Paul Slauenwhite CLA 2008-03-31 09:42:45 EDT
Reassigning to Paul S. 
Comment 12 Paul Slauenwhite CLA 2008-03-31 12:14:14 EDT
Deferring to I7 as discussed by PMC/AG (http://wiki.eclipse.org/TPTP-AG-20080331#Test_Project).
Comment 13 Paul Slauenwhite CLA 2008-04-14 14:27:53 EDT
This defect is a regression due to defect #73178, where the edit row action (context menu on a row and mouse selection on a the row number cell) and was mistakenly disabled.
Comment 14 Paul Slauenwhite CLA 2008-04-15 08:09:05 EDT
(In reply to comment #13)
> This defect is a regression due to defect #73178, where the edit row action
> (context menu on a row and mouse selection on a the row number cell) and was
> mistakenly disabled.
> 

Re-added the edit row action for both the context menu on a row and mouse selection on a the row number cell, rewrote the display logic for displaying menu items in the context menu, and resolved the exceptions when moving rows before the first and after the last row.
Comment 15 Paul Slauenwhite CLA 2008-04-15 09:30:36 EDT
Hours worked to create/test the patch.
Comment 16 Paul Slauenwhite CLA 2008-04-15 09:31:16 EDT
Created attachment 96067 [details]
Patch.
Comment 17 Paul Slauenwhite CLA 2008-04-15 09:31:40 EDT
Patch checked in to CVS (HEAD).
Comment 18 Alex Bernstein CLA 2008-05-12 09:57:37 EDT
Tested with latest available tptp (i6, I believe)
Comment 19 Paul Slauenwhite CLA 2008-05-12 15:13:06 EDT
(In reply to comment #18)
> Tested with latest available tptp (i6, I believe)
> 

Alex, I6 will not contain this fix.  Please use I7+ or a build later than April 15, when the patch was integrated (http://www.eclipse.org/tptp/home/downloads/?ver=4.5.0).
Comment 20 Paul Slauenwhite CLA 2009-02-25 11:58:59 EST
Closing by default since not closed by the originator in the 7+ months since
being resolved.  

Please reopen if the issue is still present in the latest TPTP release or the
resolution is not correct.
Comment 21 Alex Bernstein CLA 2009-02-25 14:04:34 EST
Two comments:

1) Irrelevant choices are shown in the Move Popup dialog;
2) Does not work for multiple selected rows (only one is affected)
Comment 22 Paul Slauenwhite CLA 2009-02-25 22:08:33 EST
(In reply to comment #21)
> Two comments:
> 
> 1) Irrelevant choices are shown in the Move Popup dialog;

Are you referring to before/after the selected row?  If not, please provide the list of irrelevant choices.  Please open a new defect for this behavior.

> 2) Does not work for multiple selected rows (only one is affected).

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=252958#c4.

Comment 23 Paul Slauenwhite CLA 2009-02-25 22:08:54 EST
Closing.