Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 179853

Summary:	Missing BinaryCustomCommand in the new execution framework
Product:	z_Archived	Reporter:	Navid Mehregani <nmehrega>
Component:	TPTP	Assignee:	Liz Dancy <lizdancy>
Status:	CLOSED FIXED	QA Contact:
Severity:	blocker
Priority:	P1	CC:	jkubasta, lizdancy, samwai, vss
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	closed460

Description Navid Mehregani

2007-03-28 17:07:07 EDT

The BinaryCustomCommand doesn't seem to be implemented in the new execution framework.  There is an IBinaryCommand interface in an internal package, but it's never implemented. 

This needs to be supported in order for Probekit to be migrated to JVMTI.

Marking bug as a blocker since it's blocking progress on bug 141540

Comment 1 Navid Mehregani

2007-03-28 17:09:05 EDT

Adding Liz and Vsevolod to CC list.

Comment 2 Guru Nagarajan

2007-04-02 12:18:59 EDT

I do not have the cycles to implement this in i3. Assigning it to Liz.

No there is no concept of Binary Command in the new framework. You can send any command wrapped as a string in the "org.eclipse.tptp.platform.execution.util.ICommandFragment".
So for sending a binary command you will doing the following
a) Encode the BinaryData to be sent and store it as a String.
b) The maximum length of the string allowed I believe is 2^16 so if your class file is bigger than that then there may be an issue. [Upon which you can compress the encoded string.]
c) On the recv. end decode the received string. There is a command on the agent framework side that will process the input and return the args. See the JVMTI agents on this when they recv. filters etc.

**The interface that you see in the Execution framework in an internal package is there to enable compatibility with RAC incase you want to use RAC as the AC from the new exec framework.

Comment 3 jkubasta

2007-04-12 16:07:43 EDT

Samson, can you help here?

Comment 4 Liz Dancy

2007-04-26 12:45:54 EDT

Vsevolod and I have agreed on a command format using the new execution framework command protocol. This did not require the implementation of Binary Custom Command in the sense of implementing the interface provided. Thanks to Guru for his guidance on this alternative solution. Closing this defect as the enhancement 141540 is not blocked from progress.

Comment 5 Paul Slauenwhite

2009-06-30 12:06:29 EDT

As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.