Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 179699

Summary:

type.newTypeHierarchy doesn't cancel

Product:

[Eclipse Project] JDT

Reporter:

Martin Aeschlimann <martinae>

Component:

Core

Assignee:

Jerome Lanneluc <jerome_lanneluc>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.3

Target Milestone:

3.3 M7

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

179511

Attachments:

Description	Flags
Proposed fix and rmodified test	none

Description Martin Aeschlimann

2007-03-28 05:48:34 EDT

M6

When creating a hierarchy while the indexer is updating, canceling the progress monitor doesn't have an effect. See bug 179511.

Problem is that the cancel doesn't work as
IndexBasedHierarchyBuilder.searchAllPossibleSubTypes(...) line: 522
passes in null as progress monitor.

It should probably create a dummy progress monitor that forwards calls to 'isCanceled'

IndexManager(JobManager).performConcurrentJob(IJob, int, IProgressMonitor) line: 247	
IndexBasedHierarchyBuilder.searchAllPossibleSubTypes(IType, IJavaSearchScope, Map, IPathRequestor, int, IProgressMonitor) line: 523	
IndexBasedHierarchyBuilder.determinePossibleSubTypes(HashSet, IProgressMonitor) line: 405	
IndexBasedHierarchyBuilder.build(boolean) line: 119	
TypeHierarchy.compute() line: 300	
TypeHierarchy.refresh(IProgressMonitor) line: 1237	
CreateTypeHierarchyOperation.executeOperation() line: 90	
CreateTypeHierarchyOperation(JavaModelOperation).run(IProgressMonitor) line: 720	
CreateTypeHierarchyOperation(JavaModelOperation).runOperation(IProgressMonitor) line: 779	
SourceType.newTypeHierarchy(IProgressMonitor) line: 742	
TypeHierarchyLifeCycle.createTypeHierarchy(IJavaElement, IProgressMonitor) line: 118	
TypeHierarchyLifeCycle.doHierarchyRefresh(IJavaElement, IProgressMonitor) line: 157	
TypeHierarchyLifeCycle$1.run(IProgressMonitor) line: 98	
ModalContext$ModalContextThread.run() line: 113

Comment 1 Jerome Lanneluc

2007-03-28 07:41:55 EDT

Thanks for investigating this, Martin. I'll fix it right away.

Comment 2 Jerome Lanneluc

2007-03-28 09:12:54 EDT

Created attachment 62217 [details]
Proposed fix and rmodified test

Comment 3 Jerome Lanneluc

2007-03-28 09:17:43 EDT

Fix and test released for 3.3M7 in HEAD.

Comment 4 Jerome Lanneluc

2007-04-11 13:10:01 EDT

Fix released in Startup_R32x branch.

Comment 5 Eric Jodet

2007-04-27 07:37:01 EDT

Verified for 3.3 M7 using build I20070427-0010