Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 179611

Summary: Breakpoints lost when JSP file saved
Product: [Eclipse Project] JDT Reporter: Nitin Dahyabhai <thatnitind>
Component: DebugAssignee: Michael Rennie <Michael_Rennie>
Status: CLOSED FIXED QA Contact:
Severity: blocker    
Priority: P3 CC: chanskw, david_williams
Version: 3.3   
Target Milestone: 3.3 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch none

Description Nitin Dahyabhai CLA 2007-03-27 16:34:58 EDT 
Using the WTP JSP editor (or the org.eclipse.jdt.ui.examples.javafamily example), create a JSP file with an area where you can set breakpoints (scriptlets [<% %>], etc.) and save it. Set a breakpoint into the JSP file and then make a small change elsewhere so it can be saved again.  All breakpoint markers are removed on that save.
Comment 1 Nitin Dahyabhai CLA 2007-03-27 16:42:19 EDT 
Saw this on M6, but it was also broken in M5.
Comment 2 Darin Wright CLA 2007-03-27 22:13:27 EDT 
Created attachment 62173 [details]
patch

We should not modify JSP/stratum breakpoints or pattern breakpoints when a file changes, as we do not understand the source for non-Java breakpoints.
Comment 3 Darin Wright CLA 2007-03-27 22:14:54 EDT 
Mike - it looks like the marker updater is not working properly for Java line breakpoints either - is this a know problem? For example, if I modify the line of code:

int x = fFull.size();

to be

int
   x = fFull.size();

a breakpoint on the variable decl stays in the same place, but has no effect.
Comment 4 Michael Rennie CLA 2007-03-29 10:08:01 EDT 
Applied patch.

Darin, I cannot reproduce not working breakpoints. If I use the example you provided, the marker is moved down one line, but still works fine.
Comment 5 Darin Wright CLA 2007-03-29 13:38:17 EDT 
I cannot reproduce the problem in the .java file either.
Comment 6 Darin Wright CLA 2007-03-29 13:38:28 EDT 
Verified.
Comment 7 Nitin Dahyabhai CLA 2007-06-07 16:24:26 EDT 
Closing.