Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 179292

Summary: [TabbedProperties] Need to adapt new forms look
Product: [Eclipse Project] Platform Reporter: Anthony Hunter <ahunter.eclipse>
Component: UIAssignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: aiproulx
Version: 3.3   
Target Milestone: 3.3 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
possible section treatment for properties view
none
section treatments for properties view
none
horizontal properties view - header
none
vertical properties view none

Description Anthony Hunter CLA 2007-03-26 09:03:16 EDT
The title of the tabbed properties view looks like the forms UI from 3.2.

We need to update with the look in 3.3, as per http://fullmoon.torolab.ibm.com/downloads/drops/S-3.3M5-200702091006/eclipse-news-M5.html#PDE specifically, we need to adopt the same look as shown in the title "Extensions".
Comment 1 Anthony Hunter CLA 2007-03-26 12:22:45 EDT
Created attachment 61987 [details]
patch

Patch that adopts the new forms look.

Before committing, I want to check out how the changes affect Bug 112502 and Bug 140314
Comment 2 Andrée Proulx CLA 2007-04-10 14:11:43 EDT
Created attachment 63397 [details]
possible section treatment for properties view
Comment 3 Andrée Proulx CLA 2007-04-10 14:13:55 EDT
The properties view should adopt new form look, where applicable.

The header gradient of the form can be used as is for the properties view.
Another option is to not use the background gradient, and to maintain the text and graphics elements. This may be a preferred solution for varied contexts.

The sections within the properties view can use the section treatment from the Form where applicable.
In some cases the the properties view sections may only require section heading text treatment and twistie.
Comment 4 Andrée Proulx CLA 2007-04-10 14:55:04 EDT
Comment on attachment 63397 [details]
possible section treatment for properties view

changing the file format
Comment 5 Andrée Proulx CLA 2007-04-10 14:56:22 EDT
Created attachment 63411 [details]
section treatments for properties view
Comment 6 Andrée Proulx CLA 2007-04-10 14:59:08 EDT
Created attachment 63412 [details]
horizontal properties view  - header 

ref: http://www.eclipse.org/eclipse/platform-ua/proposals/forms/enhancements-3.3/index.html

<snip>
The color used to render the title are stored in the FormColors class under the following keys (defined in IFormColors interface):

    * H_GRADIENT_START
    * H_GRADIENT_END
    * H_BOTTOM_KEYLINE1
    * H_BOTTOM_KEYLINE2

These colors are computed by starting from system colors as provided by SWT, then blending them with the background at various degrees depending on the windowing system/skin employed. They are guaranteed to work well everywhere Eclipse runs, including accessibility use cases such as 'high contrast black' and similar. Nevertheless, in order to turn this rendering on, you need to call FormToolkit.decorateFormHeading(Form).
</snip>
Comment 7 Andrée Proulx CLA 2007-04-10 15:00:21 EDT
Created attachment 63415 [details]
vertical properties view

tabbed properties view in a vertical arrangement.
Comment 8 Anthony Hunter CLA 2007-04-16 16:22:36 EDT
Committed to HEAD.