Bugzilla – Full Text Bug Listing
| Summary: | Changes to Agent Controller's plugins folder | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Navid Mehregani <nmehrega> |
| Component: | TPTP | Assignee: | Hubert Leung <hkyleung> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P1 | CC: | guru.nagarajan, hkyleung, jkubasta, randy.d.smith |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | closed460 | ||
| Bug Depends on: | |||
| Bug Blocks: | 117085, 154388 | ||
|
Description
Navid Mehregani
The components that will be affected by this are: - JVMTI - Probekit - BtM - Perfmon I've created and checked in an Eclipse plugin to hold the runtime files for perfmon. The newly added plugin is: org.eclipse.hyades.perfmon.agents. The runtime perfmon plugin only contains JAR files (it doesn't contain any native file). Thus, there were no folders created for the different platforms. This plugin should contain the same exact files as the pefrmon AC plugin. I've added the following folder structure to the org.eclipse.tptp.platform.jvmti.runtime plugin: - agent_files + linux_em64t + linux_ia32 + linux_ipf + win_em64t + win_ia32 + win_ipf Each of these folders will contain the JVMTI native code for the indicated platform. This plugin is currently not being shipped as part of TPTP's workbench plugins. This has to be done in order for the JVMTI agent to work with the new IAC. Guru, also note that you guys will need to update your pluginconfig.xml files in order for it to point to the correct location in the IAC scenario. Navid, I just refreshed my sources and I do not see the org.eclipse.tptp.platform.jvmti.runtime -> agentfiles folder. Guru, since the folders are empty, CVS automatically ignores them and doesn't check them out. They will show up once the folders are populated by the build team. Guru, Navid Please let me clarify the things. What is right and what is wrong from the following statements: 1) JVMTI profiler is going to be included to TPTP packages and AC packages in the same form: as plugins/org.eclipse.tptp.platform.jvmti.runtime. 2) This plug-in is true Eclise plug-in both in TPTP and AC packages. 3) This plug-in has identical content for all six AC packages for different platforms (i.e. win_ia32, linux_ia32, win_ipf, etc.), and includes all six native run-times at once. 1) JVMTI profiler is going to be included to TPTP packages and AC packages in the same form: as plugins/org.eclipse.tptp.platform.jvmti.runtime. >>The AC package is in <<AC_HOME>>/plugins directory as the plugin org.eclipse.tptp.javaprofiler. I will find out if the name change is possible now to have the same name on both the Client side i.e. for IAC and for AC. >>On the Eclipse WOrkbench/Client side the plugin will be called as org.eclipse.tptp.platform.jvmti.runtime. 2) This plug-in is true Eclise plug-in both in TPTP and AC packages. This is indeed a true Eclipse plugin with its configuration file. 3) This plug-in has identical content for all six AC packages for different platforms (i.e. win_ia32, linux_ia32, win_ipf, etc.), and includes all six native run-times at once. >> I will let Navid confirm this but the answer is no on this. i.e. The IAC plugin (6 AC packages) is a seperate plugin and the so is the jvmti runtime plugin. There is no IAC package that has the IAC(AC) containing the JVMTI runtime pluging. The JVMTI runtime plugin is a seperate plugin that includes all the 6 platform packages together per comment #2 Kiryl, Number 1 and 2 are correct. For #2, the org.eclipse.tptp.javaprofiler plugin should be replaced by org.eclipse.tptp.platform.jvmti.runtime. As for #3: Since we have separate download links for each platform of the *stand-alone* AC, it doesn't make sense to include the native files for all the platforms in the this plug-in for the AC case. For example, if someone downloads the AC for windows IA32, then that plugin should only contain the native files in the win_ia32 folder. All the other folders can be empty. However, for the IAC scenario, we'll need to include the native files for all the platforms in this plug-in. Now, there is a possibility that we might introduce separate download links for TPTP's workbench plugins as well, but this hasn't been confirmed yet. For now, I'd rather include all the native files in this plugin for the IAC scenario. We can take care of this later, if we do decide to include separate download links for TPTP's workbench. Guru, I do not see org.eclipse.tptp.platform.jvmti.runtime plug-in in TPTP packages. I expect this one is prepared by upstream build (Hubert) and then downstream build (me) populates it with native code. As this is done for org.eclipse.tptp.platform.ac.*. The plug-in should be just a placeholder, i.e. includes only Eclipse specific plug-in files (plugin.properties, META-INF/MANIFEST.MF). I can not create plug-in in downstream build because it is Eclipse specific. For example the plug-in should be declared as part of some feature. As I've noted above, the org.eclipse.tptp.platform.jvmti.runtime plug-in is currently in CVS, but it's not being built into our drivers. Hubert, can you please include this plug-in as part of TPTP's drivers so Kiryl can populate it with JVMTI's native files? Kiryl, I'm reassigning this bug to you. Please close it if your part is done. Kiryl, the org.eclipse.platform.jvmti.runtime plug-in has been included as part of TPTP's workbench plug-ins (Thanks!), but this plug-in hasn't replaced org.eclipse.tptp.javaprofiler in the plugins folder of the stand-alone Agent Controller. Actually, let's keep the stand-alone AC packaging the same for now. We could make things more complicated if we change it now. Hubert, I noticed that the 'org.eclipse.hyades.perfmon.agents' AC plugin is still not being included as part of the workbench plugins. This has to be done in order for perfmon to function properly with the new IAC. Can you please let me know when you're planning to do this by? It seems my part is done. Hubert, reassigning to you to complete org.eclipse.hyades.perfmon.agents. org.eclipse.hyades.perfmon.agents is now in the build. org.eclipse.hyades.perfmon.agents is in the build now (TPTP-4.4.0-200705041104). Right now it is packed as a jar but I already changed the feature to unpack it. The next builds will have the plugin unpacked. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |