Bugzilla – Full Text Bug Listing
| Summary: | Define global Bugzilla flags | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Community | Reporter: | Denis Roy <denis.roy> | ||||
| Component: | Bugzilla | Assignee: | Eclipse Webmaster <webmaster> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | caniszczyk, john.arthorne, phperret | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | 177815 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Denis Roy
blog about this Denis plz You're too quick - I'm in the process of writing one of my patented Webmaster Updates to get committers talking about the Flags. After opening a bug, the default 'Assigned To:' attribute is Eclipse Webmaster. Shouldn't it be to the Reporter? (In reply to comment #3) > After opening a bug, the default 'Assigned To:' attribute is Eclipse Webmaster. > Shouldn't it be to the Reporter? It depends where you open a bug. Each Bugzilla component is owned by someone. The Community/Bugzilla component happens to be owned by webmaster. There wasn't too much feedback on this, so I went ahead and created three global flags that I think may be useful for all projects. This may generate discussion: review: request a code review/flag as reviewed pmc_approval: request PMC/project lead approval / flag as reviewed documentation: flag to indicate documentation has been updated. Hey Denis, is it possible to have flags associated with patches (ie., attachments)? Yes... what do you have in mind? if it's possible to associated flags with patch attachments, go for it. I want something similar to how Mozilla does it. Look at this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=247116 for how they approve patches. (In reply to comment #8) > if it's possible to associated flags with patch attachments, go for it. Mozilla seems to create flags for each version (approve1.8.0.4) for instance. I'm not ready for that. If I add generic global flags for attachments, such as 'review' and 'approve', would that be sufficient? do they? I would just like a simple "review+" patch rev 2 (2.20 KB, patch) 2007-03-16 17:40 PDT, Dave Townsend (Mossop) gavin.sharp: re versions are too fancy for me :) If it's too much now, we can open a separate bug to track this specific issue and ask for community comments. (In reply to comment #10) > do they? I would just like a simple "review+" That makes sense. I added a review flag for attachments. (In reply to comment #5) > review: request a code review/flag as reviewed > pmc_approval: request PMC/project lead approval / flag as reviewed > documentation: flag to indicate documentation has been updated. This may be too-late nitpickery, but would the following be slightly better? reviewed pmc_approved doc_updated In this way, it's a boolean status code rather than a non-boolean category. Before reading the definitions, I wasn't sure if "review" meant 'we request a review' or 'has been reviewed'. Obviously, it's both... but "review [+]" could also be seen to mean "yes, I agree, this needs a review, if we get enough votes we'll schedule a meeting" rather than "reviewed and I concur." Created attachment 63780 [details]
test.patch
Denis, can you vote on the dummy patch? I'm curious what it looks like :) Comment on attachment 63780 [details]
test.patch
Doesn't pass my review. 6 bytes is too much code.
Comment on attachment 63780 [details]
test.patch
I prefer blech but blah is also API.
Comment on attachment 63780 [details]
test.patch
Test comment from Mike
I'm a bit confused about the "documentation" flag. Does this have any value over the "documentation" keyword? What would setting doc flag to "-" mean? (In reply to comment #18) > I'm a bit confused about the "documentation" flag. Does this have any value > over the "documentation" keyword? What would setting doc flag to "-" mean? Hrm. I just sent out a committer e-mail that attempts to define these. Actually, I hadn't seen that there was a documentation keyword so I can remove it if it's redundant. Ok, we'll see what others think. The other flags make sense to me. Thanks for adding this! How do you set up search queries based on flags. What does the flag equal? +? -? Or does the flag equal "review" or "pmc_approved"? How do we know what the value then of the flag is? |