| Summary: | [painting] Print margin drawn on top of text | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | George Hedges <george> | ||||||||||
| Component: | Text | Assignee: | Paul Pazderski <paul-eclipse> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | minor | ||||||||||||
| Priority: | P3 | CC: | alhashash, artist, bogofilter+eclipse.org, bsi.msa, clayj_99, daniel.stein, daniel_megert, devguy.ca, fantaman, gjohnson, Jens.Rutschmann, michael.schneider3, mikko.rantalainen, paul-eclipse, sgbmyr | ||||||||||
| Version: | 2.0 | ||||||||||||
| Target Milestone: | 4.13 M3 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| See Also: |
https://git.eclipse.org/r/146518 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=fc1d1922254505a0762ea836f57681a322aadcbc |
||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
George Hedges
not critical Reopening for 2.1 consideration *** Bug 19746 has been marked as a duplicate of this bug. *** *** Bug 341088 has been marked as a duplicate of this bug. *** I can confirm this issue with Eclipse 3.6.1 on Gentoo Linux. This issue did not appear with the 3.5 releases. I also experience this behaviour beginning from eclipse 3.6 (in 3.7 it is still present). I find this quite annoying since it really impairs the legibility of code and can lead to actually confusing words as certain letters appear like other ones, e.g. 'n' appears like 'r' when the print margin happens to fall onto the respective column. > This issue did not appear with the 3.5 releases.
I would tend to disagree (and at least on Windows 7 the problem can also be seen in 3.5) as the painter is invoked after drawing the characters.
Maybe used to use a different font in 3.5 and the problem was less visible? > Maybe used to use a different font in 3.5 and the problem was less visible?
I always use the default font settings; if it's another font, then it had been "changed" by eclipse. But actually I don't think that I now have a different font than in 3.4 or so.
Created attachment 215163 [details]
Print-margin not just over text, but also 'in' the text
Screenshot that shows that the 'print margin' is overlapping the text. However, it is also 'inside' text, as text is both to the left, and to the right of the margin. It seems the margin should be a few pixels to the right?
My operating system is: CentOS 5.8 with KDE.
I'm seeing this as well in: Version: 4.2.1 Using Mac OS 10.7.5 I'm experiencing the same problem in 4.3.1 running Gentoo Linux. Created attachment 239397 [details]
Legibility degrades as text become altered
Screenshot from 4.3.1.
Comment on attachment 239397 [details]
Legibility degrades as text become altered
This should read "Sans" not "Sars".
Still exists in 4.5.1 (13 years later). "not critical" But still a PITA. Still exists in 4.10.0RC1 (16 years later). This bug has been marked as ASSIGNED for a really long time with no progress. I guess the status should be reset. You are not wrong but since the assignee is the inbox it doesn't really count as assigned anyway. Created attachment 279376 [details]
wrong and fixed print margin
17 years... and finally someone found time to look into this.
The margin painter missed to consider the widgets margin. See attached screenshot.
Created attachment 279377 [details]
code used for the screenshot
New Gerrit change created: https://git.eclipse.org/r/146518 *** Bug 497608 has been marked as a duplicate of this bug. *** Gerrit change https://git.eclipse.org/r/146518 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=fc1d1922254505a0762ea836f57681a322aadcbc |