Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 177827

Summary: inside border in propetry editor.
Product: z_Archived Reporter: Aashima Goel <agoel>
Component: BIRTAssignee: Zhiqiang Qian <zqian>
Status: RESOLVED WONTFIX QA Contact:
Severity: enhancement    
Priority: P3 CC: kvenkatraman, qwang, rkanguri, wenfeng.fwd, whe, wyan, xxue
Version: unspecifiedKeywords: plan
Target Milestone: Future   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
suggested mockup having additional border capabilities
none
middle borders in excel
none
borders in BIRT none

Description Aashima Goel CLA 2007-03-16 15:45:00 EDT
For tables and grids we provide borders. Right now there is no option to provide border for the grid or table cells.
This is important when user wants to have cell borders.
Comment 1 Aashima Goel CLA 2007-03-16 17:56:06 EDT
Created attachment 61173 [details]
suggested mockup having additional border capabilities
Comment 2 Wang Qiangsheng CLA 2007-04-09 18:21:13 EDT
I don't think we can have the borders setting of middle borders. The reason is the BIRT table let every cell setting it's own borders. So what's the middle borders? Will the borders set on all cells at both left and right or only set on only left or right? If we select a table with some cells set with border, who shall GUI do? reset them all?
So please re-think about the GUI with the idea that all cells have separate border setting. One middle line in the mock up means several cell borders in BIRT table.
Thanks
Comment 3 Aashima Goel CLA 2007-04-16 14:54:23 EDT
take excel for example. We can have borders at cell level also. The preview looks neat having the middle borders. One can select the row and select the middle borders that divides the row cells with borders. (See attachment: excel borders)

In BIRT we do have capability of having cell borders but looks wise it does not divide the cells evenly. As a result we do not have a good looking report (see attachment:BIRT borders)

The significance of having borders at cell level is the same in EXCEL and BIRT, while excel divides the cells evenly having middle borders while BIRT does not. No matter the content in that cell is occupied or not.
Comment 4 Aashima Goel CLA 2007-04-16 14:55:16 EDT
Created attachment 63941 [details]
middle borders in excel
Comment 5 Aashima Goel CLA 2007-04-16 14:55:46 EDT
Created attachment 63942 [details]
borders in BIRT
Comment 6 Wang Qiangsheng CLA 2007-05-23 18:40:37 EDT
We'll if we want to have the result as you suggest, we need make the changes in model,engine and GUI teams. It's not an enhancement that GUI can do. It's following the CSS definition. Also the GUI setting will not resolve the preview issue as the borders in BIRT shown.
This changes need review before really happening.
Thanks


(In reply to comment #3)
> take excel for example. We can have borders at cell level also. The preview
> looks neat having the middle borders. One can select the row and select the
> middle borders that divides the row cells with borders. (See attachment: excel
> borders)
> 
> In BIRT we do have capability of having cell borders but looks wise it does not
> divide the cells evenly. As a result we do not have a good looking report (see
> attachment:BIRT borders)
> 
> The significance of having borders at cell level is the same in EXCEL and BIRT,
> while excel divides the cells evenly having middle borders while BIRT does not.
> No matter the content in that cell is occupied or not.
> 

Comment 7 Wenfeng Li CLA 2007-05-30 19:49:16 EDT
assign to model to define shared boardors for cells in table and grid, please assign to engine and then UI to support this feature.
Comment 8 Wei Yan CLA 2007-05-30 23:42:24 EDT
it seems that the user sets the border in the inner text instead of the cell. 

In Excel, each cell can contain only one element, so there is no need to define the border of the inner content. In BIRT, each cell can contain multiple element and each element can have its own border.

Excel's middle border is a shortcut to define borders for multiple cells. The user can select multiple cells and define the border between the cells and left the outmost border of the cells empty. 

So i think we needn't create a new MODEL for this behavior.
Comment 9 Ivy Li CLA 2007-07-05 05:23:29 EDT
We don't need new model for this feature. If BIRT wants to support the feature that the mock up gave out, GUI need to provide the inner border settings from property editor, and according to a certain border that user choose, to set the border property on each cell to create the expected border preview layout. 

Model can provide a way to remember the type of inner border setting from user, then GUI can re-selected the setting for the property editor next time when user open the report. 
Comment 10 Wenfeng Li CLA 2007-07-10 19:11:16 EDT
suggest to add border support for cell in table, grid, and Xtab.  Don't we need to enhance model, engine and UI to support borders on cell?

This enh is not for borders on the report item, but borders on the cell.

add plan key word, since this is more like a new project that require coordinations between components..
Comment 11 Zhiqiang Qian CLA 2007-11-19 05:15:08 EST
We need those new border type icons in UI.
Comment 12 Rima Kanguri CLA 2008-06-03 02:48:58 EDT
Border cell is already supported. This enhancement is requesting, mechanism to allow user to set border on mutliple cells, by seting the propert on table.

Please investigate. I am ok canceling this bug.
Comment 13 Wenfeng Li CLA 2008-06-09 21:08:53 EDT
canceling this bug.