Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 177334

Summary: SharedHeaderFormEditor needs services for header
Product: [Eclipse Project] Platform Reporter: Christof Marti <christof_marti>
Component: UIAssignee: Paul Webster <pwebster>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: agarcher, andre_weinand, curtispd
Version: 3.3   
Target Milestone: 3.4 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 184074    
Bug Blocks:    

Description Christof Marti CLA 2007-03-14 09:56:51 EDT
3.3M5

Each editor page appears to have its own nested services for keybindings, handlers, contexts and possibly others. The editor header also needs its own services. (At least from what I understand.)
Comment 1 Paul Webster CLA 2007-11-26 09:54:02 EST
Adam, Christof, I was thinking of adding a new API to MultiPageEditorPart, something like:

IServiceLocator getPageSite(int index)

It will work under the same restrictions as setActivePage(int).  For an editor page, it will return the editor site (as an IServiceLocator).  For a control page, it will lazily create and return an IServiceLocator.

Changing pages will continue to activate/deactivate the new service locators as well as the editor sites.

I'll provide a constant for the page container site that can be used for the shared header site:
protected static final int PAGE_CONTAINER_SITE = 65535;

Then I'll enhance the API in Bug 184074 so that you have the option of activating the page container site when deactivating the page site.

PW
Comment 2 Paul Webster CLA 2007-11-30 12:07:23 EST
Released to HEAD >20071130
PW
Comment 3 Paul Webster CLA 2007-12-11 12:44:22 EST
In I20071211-0010
PW