Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 176300

Summary: Don't use SWT.DEFAULT in GridDataFactory.align()
Product: z_Archived Reporter: Willian Mitsuda <wmitsuda>
Component: MylynAssignee: Michael Valenta <Michael.Valenta>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: anlarionov, benno.baumgartner, krzysztof.daniel, tomasz.zarna
Version: dev   
Target Milestone: 2.0 M2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch for Bugzilla/UI
none
mylar/context/zip none

Description Willian Mitsuda CLA 2007-03-03 20:05:14 EST 
They added a safety check on GridDataFactory.align() to throw a IllegalArgumentException for invalid values on latest N-builds.

SWT.DEFAULT is not a valid value according the javadoc, and is being used in some places, like AbstractRepositoryTaskEditor.createPeopleLayout(), making HEAD broke when used with latest N-builds.
Comment 1 Mik Kersten CLA 2007-03-03 20:10:59 EST 
We probably won't have time to get to this before EclipseCon, but patch welcome if this is holding you up.
Comment 2 Robert Elves CLA 2007-03-12 17:44:28 EDT 
*** Bug 176524 has been marked as a duplicate of this bug. ***
Comment 3 Robert Elves CLA 2007-03-12 17:45:04 EDT 
Fixed.
Comment 4 Michael Valenta CLA 2007-03-14 10:59:55 EDT 
The bug is not fixed. The vertical and horizontal alignment values are in the wrong order.
Comment 5 Michael Valenta CLA 2007-03-14 11:00:48 EDT 
Created attachment 60808 [details]
Patch for Bugzilla/UI

Here's a patch for AbstractRepositorySettingsPage.java. There are probably other places where the values are reversed.
Comment 6 Mik Kersten CLA 2007-03-14 16:38:36 EDT 
Patch applied, thanks Michael!
Comment 7 Mik Kersten CLA 2007-03-14 16:41:00 EDT 
Done.
Comment 8 Mik Kersten CLA 2007-03-14 16:41:02 EDT 
Created attachment 60862 [details]
mylar/context/zip
Comment 9 Michael Valenta CLA 2007-03-15 10:14:03 EDT 
*** Bug 177547 has been marked as a duplicate of this bug. ***
Comment 10 Michael Valenta CLA 2007-03-15 10:18:42 EDT 
*** Bug 177551 has been marked as a duplicate of this bug. ***
Comment 11 Mik Kersten CLA 2007-03-21 13:53:37 EDT 
*** Bug 177932 has been marked as a duplicate of this bug. ***
Comment 12 Mik Kersten CLA 2007-03-26 11:39:08 EDT 
*** Bug 178973 has been marked as a duplicate of this bug. ***