| Summary: | [new uex] provide link for creating new account or changing settings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Mik Kersten <mik.kersten> | ||||
| Component: | Mylyn | Assignee: | Mik Kersten <mik.kersten> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | blocker | ||||||
| Priority: | P3 | CC: | balazs.brinkus, robert.elves, steffen.pingel | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 2.0 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 359147 | ||||||
| Attachments: |
|
||||||
|
Description
Mik Kersten
Isn't it duplicate of bug 149607 ? No, I'm imagining that this will pop up a connector-provided URL for a web page that allows you to create an account. So they're very similar, but the other is about improving the missing credentials story and this one is about improving the "new user, no credentials" story. Hmm. Those stories look the same to me. Note that credentials could be lost while switching between several Eclipse installs. So, it seem good idea to bring up same repository configuration dialog in either case. Mylar needs to provide generic facilities to prompt users for a password in case they don't want to save it and cache it for the session (the way CVS does it). That dialog could also include a link to create an account. Since authentication is repository specific this needs to be handled separately for each connector but we could have a generic ui and provide means to store/cache credentials (we have that already in TaskRepository). We now have facilities for detecting when account settings are gone (bug 149607). I added hyperlinks to the repository settings page for account creation and management. A connector should implement these by overriding AbstractRepositoryConnectorUi.getAccountCreationUrl(..) and getAccountCreationUrl(..) to return the URLs. Added overrides for Bugzilla. I also cleaned up the page some by creating an Additional Settings foldable for repository-specific stuff like character encoding Balzas: note that this change ensures that your workflow through the task repository creation cheat sheet enables users to get their bugs.eclipse.org org account. Created attachment 68868 [details]
mylar/context/zip
(In reply to comment #5) > I also cleaned up the page some by creating an Additional Settings foldable for > repository-specific stuff like character encoding We should really move away from those foldable sections and use proper multi-page Properties dialog By the way, those urls should be accessible trough AbstractRepositoryConnector and not trough AbstractRepositoryConnectorUi. We already have some url-related stuff in the connector, so those urls also belong there and we probably should aslo move activity/history url from task editor subclass to the same place. (In reply to comment #5) > I also cleaned up the page some by creating an Additional Settings foldable for > repository-specific stuff like character encoding Mik, apparently this particular change broke layout of the web repository connector and I am having troubles to fix it. Also see bug 189496 which is related to other changes you made for this issue. This commit also causes createAdditionalControls() only to be called when needsEncoding() is true. This is not the case for Trac resulting in a broken property page and failed tests. BTW, Mik, you could have avoided this bug if NPE dereference detector would been enabled in all Mylar projects. See Project / Preferences / Java Compiler / Errors/Warnings / Potential programming problems / Null pointer access (and probably Potential null pointer access). BTW, Mylar would make an excellent case for continuous build. Are there any Eclipse projects out there doing that? (In reply to comment #12) > BTW, Mylar would make an excellent case for continuous build. Are there any > Eclipse projects out there doing that? http://www.pluginbuilder.org/ Looks like Steffen has fixed the layout (I did a quick check of Trac and Web Connector repositories). |