Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 174739

Summary:

[Viewers] TableViewer - Combo cell editor - on single click needs to open

Product:

[Eclipse Project] Platform

Reporter:

Hariharan <hariharan.sethuraman>

Component:

Assignee:

Thomas Schindl <tom.schindl>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

bokowski, hariharan.sethuraman, tom.schindl

Version:

3.2.1

Flags:

bokowski: review+

Target Milestone:

3.4 M6

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

175473, 175474

Bug Blocks:

Attachments:

Description	Flags
Patch to add the auto-drop-down feature to CellEditors	none
A test snippet	none
Revised to make this feature available to both ComboCellEditor-Impl	none
this time the correct patch	none

Description Hariharan

2007-02-20 02:49:36 EST

Build ID: M20060921-0945

Steps To Reproduce:
1. Create a table viewer with combo cell editor in any column.
2. Add a model to the table viewer.
3. Click on any row of the combo cell editor column
4. The combo needs to get open on single
(Actual it is activated and user have to click again to open the combo.)

Issue#2
5. The one more issue is - if the combo has more than 1 or 2 items, on Hovering over combo items, the selection blue colour is not applied on the current mouse cursor item.

In both the issues, the end user needs the comboeditor's combo to function as a swt.widgets.combo.

Ref: window>preferences>Team>FileContent page

More information:

Comment 1 Thomas Schindl

2007-02-23 09:49:09 EST

1. Issue: What do you mean with activated? Does this mean you want DropDown-List to be shown automatically when you click the item? If this is the case you need to log a feature request against SWT and ask if they want to open CCombo#dropDown to the public so JFace would have access to it and automatically popup the DropDown.

2. Issue: This request is definately one you need to file against SWT the problem is that CCombo uses a List to emulate the drop down and in lists this hover effect doesn't exit. If you filed the bugs against SWT you can reference this bug to depend on them.

Comment 2 Hariharan

2007-02-25 23:47:56 EST

For issue#1: POSTED AS REQUEST

https://bugs.eclipse.org/bugs/show_bug.cgi?id=175473


and for Issue#2
Changing the component to SWT

Comment 3 Hariharan

2007-02-26 00:05:01 EST

For Issue#2. posted as separate bug @ https://bugs.eclipse.org/bugs/show_bug.cgi?id=175474

Comment 4 Thomas Schindl

2008-02-12 07:34:47 EST

Created attachment 89487 [details]
Patch to add the auto-drop-down feature to CellEditors

Comment 5 Thomas Schindl

2008-02-12 07:35:37 EST

Created attachment 89488 [details]
A test snippet

Comment 6 Thomas Schindl

2008-02-12 07:37:17 EST

Boris I think it is worth that we provide this feature to JFace customers although one could argue that they could easily implement it their own.

Comment 7 Thomas Schindl

2008-02-12 07:52:50 EST

Created attachment 89489 [details]
Revised to make this feature available to both ComboCellEditor-Impl

Comment 8 Thomas Schindl

2008-02-12 07:53:53 EST

Created attachment 89490 [details]
this time the correct patch

Comment 9 Thomas Schindl

2008-02-20 14:23:28 EST

Phone-Conference:
- typo in TRAVSE_ACTIONVATION
- usage of != 0 is bit masks

Comment 10 Thomas Schindl

2008-02-20 15:39:40 EST

released with requested changes to HEAD >= 20080220

Comment 11 Thomas Schindl

2008-03-27 09:25:29 EDT

Verified in build I20080326-1950

Comment 12 Thomas Schindl

2008-03-27 09:25:49 EDT

forgot to switch resolution