Bug 174473

Comment 1 Robert Elves 2007-06-26 17:41:20 EDT

Balazs: you interested in taking this on, since it is a New User Experience thing?

Comment 2 Balazs Brinkus 2007-07-22 14:22:33 EDT

Created attachment 74313 [details]
repository wizard

I included the new query pages in the repository wizard.
I tested it with the bugzilla and trac connectors. They are working. I have to test with jira connector (I have to create an account for the test).
It contains some "ugly" code parts (NewRepositoryWizard), I'd like to make it more simple.
What do you think about this solution? If it's good, I will finish it.

Comment 3 Balazs Brinkus 2007-07-22 14:22:42 EDT

Created attachment 74314 [details]
mylyn/context/zip

Comment 4 Eugene Kuleshov 2007-07-22 16:05:22 EDT

I think it is not really a good idea to introduce new API for this feature that would require to change all existing connectors. More over many connectors have multipage query configuration, which won't be possible to handle with this API. So, I see two possible options how this could be implemented without adding new API:

1. wrap wizard returned from AbstractRepositoryConnectorUi.getQueryWizard(). This approach is used for example by the NewQueryWizard. It is probably a bit tricky to implement and it also have not very good discoverability characteristics. Also it doesn't not clearly separate query creation from the repository creation, i.e. if if you cancel wizard from the query page would it cancel just query creation or also repository?

2. much simpler UI. after completing repository wizard user can be asked "Would you like to add query for this repository?" and if he say yes, the regular query wizard can be invoked (skipping repository selection page).

Personally I am leaning towards 2nd option.

Comment 5 Balazs Brinkus 2007-07-22 18:01:35 EDT

Yes, the 2nd option is more simple than my solution. I'm going to implement this.

Comment 6 Mik Kersten 2007-07-23 14:37:14 EDT

+1 for the 2nd option, this is what I had in mind originally, since this is more of a convenience UI for newcommers and a PONT (point of needed training) interaction than something that corresponds to a single wizard flow-through. 

Balazs: in general please post the approach to implementing the UI before doing so, because it helps us iterate on feedback before too much coding is done.  In general if I'm around you should expect at most a 1-2 day wait on a response from me on UI questions.

Since this is a PONT, use MessageDialogWithToggle so that the user can dismiss it if they don't want to see this again.  Here's an example:

							if (!getPreferenceStore().getBoolean(PREF_WARN_DISABLED)) {
								MessageDialogWithToggle dialog = MessageDialogWithToggle.openWarning(
										PlatformUI.getWorkbench().getDisplay().getActiveShell(), "JDK Version Check",
										"Mylyn was installed but requires Java 5 or later to run. "
												+ "Please download and install the latest Java version and restart.",
										"Do not warn again", false, getPreferenceStore(), PREF_WARN_DISABLED);
								getPreferenceStore().setValue(PREF_WARN_DISABLED, dialog.getToggleState());
							}

Comment 7 Balazs Brinkus 2007-07-23 19:54:58 EDT

Created attachment 74404 [details]
repository wizard v1

I created a new solution.
I can understand the instructions for the UI.

Comment 8 Balazs Brinkus 2007-07-23 19:55:05 EDT

Created attachment 74405 [details]
mylyn/context/zip

Comment 9 Mik Kersten 2007-07-27 10:37:48 EDT

Rob: please review.

Comment 10 Robert Elves 2007-07-27 15:21:52 EDT

Looks good. Patch applied, ip log updated.

Comment 11 Mik Kersten 2007-09-04 19:05:26 EDT

*** Bug 202102 has been marked as a duplicate of this bug. ***