Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 174460

Summary: [Usability] Missing/inconsistent titles/descriptions/icons in test report dialogs.
Product: z_Archived Reporter: Paul Slauenwhite <paulslau>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 Keywords: plan
Version: unspecifiedFlags: paulslau: review-
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch version 1
none
Patch V2 none

Description Paul Slauenwhite CLA 2007-02-16 11:31:26 EST
[Usability] Missing/inconsistent titles/descriptions/icons in test report dialogs.

The title in test report dialog for the following report types is missing (TPTP-4.4.0-200702050100):

XML Test Report
HTML Tabular Test Report (BIRT)
HTML Test Pass Report (BIRT)

Also, the icons for the above report types should be replaced with a more meaningful icon instead of the ubiquitous file icon.

Finally, the title, name and description of each wizard page for all report types in the test report dialog are inconsistent.  We should attempt to have consistent titles, names and descriptions for both the report types, and their wizard pages so the user has a uniform and meaningful presentation.  For example, the description of the HTTP Page Response Time is:

Create a new Report.
Comment 1 Sheldon Lee-Loy CLA 2007-02-16 11:46:47 EST
As discussed with originator I'm changing the target to future and priority to P2.  
Comment 2 Paul Slauenwhite CLA 2007-03-02 08:56:08 EST
Defect owner, please provide a sizing for this defect.
Comment 3 Paul Slauenwhite CLA 2007-05-16 08:29:42 EDT
We are using the Test.UI.Reporting component for test reports.
Comment 4 Paul Slauenwhite CLA 2007-10-03 06:39:23 EDT
Reassigning to Project Lead until a Lead Committer is assigned to this component.
Comment 5 Paul Slauenwhite CLA 2007-12-10 11:28:44 EST
In TPTP 4.5, the BIRT Test Report generators was moved from a General Availability (GA) component to an As-Is component. As-Is components are primarily provided for prior users but imply no support (for example, defects, news group, and mailing lists) or commitment to triage or resolve opened defects. For this defect to be considered, please re-open with an attached patch including code to resolve the symptom and test cases to test the fix.
Comment 6 Paul Slauenwhite CLA 2007-12-10 11:28:56 EST
Closing.
Comment 7 Paul Slauenwhite CLA 2007-12-10 11:57:15 EST
Reopening to resolve non-BIRT test report issues.
Comment 8 Paul Slauenwhite CLA 2008-01-30 12:14:32 EST
Deferred from I5 to I6 with PMC approval.
Comment 9 Tony Wang CLA 2008-03-07 13:02:24 EST
Created attachment 91904 [details]
patch version 1

patch version 1
Comment 10 Tony Wang CLA 2008-03-07 13:34:24 EST
Hi paul, In the attached patch version 1, I've changed some inconsistent descriptions, added missing titles for those three reports mentioned in the description above and gave the other two reports more meaningful titles

and there are still some problems: 
1.for icon issue, could you find more meaningful icons for the report and add them? they should be added to the same place as the new title in the patch, and the code to add icons is like the one in ReportWindowWizard.java:

setDefaultPageImageDescriptor(TestCommonImages.INSTANCE.getImageDescriptor(TestCommonImages.IMG_WIZBAN_REPORT_WINDOW));

2.since those five reports are in different types, the error message are inconsistent, like messages for empty file name/empty project/invalid file name..etc. and the meeages are saved in different places, for xml report, it's saved in 
org.eclipse.tptp.platform.report.birt.ui.messages.properties
for other two type: BIRT/Time Frame Historic&Test Pass, I imported all birt packages in platform and test folder, but still can't find the message

Could you review the patch attached above and look at these two problems? Thanks a lot!
Comment 11 Paul Slauenwhite CLA 2008-03-31 12:14:23 EDT
Deferring to I7 as discussed by PMC/AG (http://wiki.eclipse.org/TPTP-AG-20080331#Test_Project).
Comment 12 Paul Slauenwhite CLA 2008-04-10 09:21:24 EDT
Patch reviewed (see patch V2).

Tony, I am assigning this defect back to myself since I will handle #1 and #2 in comment #10 (see patch V2).
Comment 13 Paul Slauenwhite CLA 2008-04-10 10:52:11 EDT
Hours for creating and testing version 2 of the patch.
Comment 14 Paul Slauenwhite CLA 2008-04-10 10:52:22 EDT
Created attachment 95537 [details]
Patch V2
Comment 15 Paul Slauenwhite CLA 2008-04-10 10:52:50 EDT
Patch V2 checked in to CVS (HEAD).
Comment 16 Paul Slauenwhite CLA 2008-06-10 10:56:49 EDT
Verified in TPTP-4.5.0-200806070100.  Closing.