Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 17431

Summary: Accessibility issues
Product: [Eclipse Project] Platform Reporter: Kevin McGuire <Kevin_McGuire>
Component: CompareAssignee: Dani Megert <daniel_megert>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P2 Keywords: accessibility
Version: 2.0   
Target Milestone: 2.0 F2   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Kevin McGuire CLA 2002-05-23 14:07:43 EDT 
1- The compare actions such as next/previous, and others represented by the 
second set of compare buttons (show ancenstor pane, etc.) are all 
inaccessible.  The only accessible actions are those in the view title bar 
itself.  At least, not that I've discovered.

2- There used to be accelerators for next/previous change.  I don't recall what 
they are, but haven't hit on them.  Do we still have any? 

3- If there are actions for next/previous, then they cannot be discovered 
because there is no menu in which they would appear.
Comment 1 Erich Gamma CLA 2002-05-26 05:01:11 EDT 
>3- If there are actions for next/previous, then they cannot be discovered 
>because there is no menu in which they would appear.
should do the same as in search and show the short cut in the toolbar.
Comment 2 Andre Weinand CLA 2002-05-29 05:11:55 EDT 
1) Navigate to the pane's tool bar with Control-Tab until the first ToolItem is 
active. Navigate through the ToolItems with the cursor keys. Use Enter to 
trigger the tool item (this works in Synchronize view too).

2+3) Yes, Cntrl-E and Cntrl-Shift-E are used to step through changes globally 
(not confined to single file), without stepping into token diffs. The 
CompareViewer has two buttons for this in the global tool bar (like the Java 
editor for stepping through problems). The accelerator for these actions 
are shown in the tooltip description (Cntrl-E and Cntrl-Shift-E).
This works in Synchronize view too as long as no Java editor is open.
If a Java editor is open it doesn't work because of #18134.
Comment 3 Kevin McGuire CLA 2002-05-29 13:13:15 EDT 
Re #1:  confirm that I can access them this way.  However, there is a case 
where it doesn't work:

1. compare with latest/whatever
2. pick "Copy All from Right to Left"
3. now select the file again to get known starting point for cntrl-tab.
4. you can't control-tab to the "Copy All from Right to Left", even though its 
still enabled.

Re #2/3: Other reason why I've reopened this bug is because I am concerned this 
isn't sufficient.

If you don't have a mouse, you need to use accelerators, but as far as I know 
you can't get tooltips without a mouse.  Maybe there's a way I am unaware of.
Comment 4 Andre Weinand CLA 2002-05-29 13:28:19 EDT 
Re #1: will investigate

Re #2/3: arch call today: workbench will add global next/prev actions to the 
navigate menu. I will remove my keylisteners and hook up with the global 
actions for next/prev. They will have accelerators and you can find them 
without mouse and tooltips.
Comment 5 Andre Weinand CLA 2002-05-31 09:03:05 EDT 
fixed #2/3 for 20020601
Comment 6 Andre Weinand CLA 2002-05-31 13:19:21 EDT 
#1: works for me in 20020601
Comment 7 Erich Gamma CLA 2002-06-02 17:49:42 EDT 
pls verify
Comment 8 Dani Megert CLA 2002-06-03 05:38:30 EDT 
Need to clear resolution due to bugzilla bug (it changed the resolution to NEW)
Comment 9 Dani Megert CLA 2002-06-03 05:41:28 EDT 
Marking bug as fixed again (due to bugzilla bug)
Comment 10 Dani Megert CLA 2002-06-03 10:51:15 EDT 
Verified all three cases in build F2
==> OK