Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 173899

Summary: Incorrect code in PanningSelectionTool
Product: [Tools] GEF Reporter: Pratik Shah <ppshah>
Component: GEF-Legacy GEF (MVC)Assignee: Pratik Shah <ppshah>
Status: RESOLVED FIXED QA Contact:
Severity: trivial    
Priority: P3    
Version: 3.2   
Target Milestone: 3.3.0 (Europa) RC1   
Hardware: PC   
OS: All   
Whiteboard:

Description Pratik Shah CLA 2007-02-12 13:45:28 EST
PanningSelectionTool#handleDrag(), line 126 reads:

return super.handleDragInProgress();

I think that was meant to be super.handleDrag().  Even if it needs to invoke handleDragInProgress(), it shouldn't be invoking that on super.

Note that this small error has no effect because both the super methods do nothing.  Hence, I'm marking it as trivial.  I just chanced upon that code and did not run into it because of some incorrect behaviour in the editor.
Comment 1 Pratik Shah CLA 2007-05-18 17:02:38 EDT
Fixed.  Changed the code to invoke super.handleDrag().